Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Sep 13, 2022

While working on #36095 I realized we have several golden-related helpers that are duplicated throughout our tests. This PR attempts to clean up the duplicates.

  • matchSceneGolden()
  • matchPictureGolden()
  • canvasScreenshot()
  • checkScreenshot()
  • setUpStableTestFonts()

As a future effort, we may want to unify some of these helpers.

@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Sep 13, 2022
@skia-gold
Copy link

Gold has detected about 2 new digest(s) on patchset 1.
View them at https://flutter-engine-gold.skia.org/cl/github/36122

Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@skia-gold
Copy link

Gold has detected about 2 new digest(s) on patchset 2.
View them at https://flutter-engine-gold.skia.org/cl/github/36122

@skia-gold
Copy link

Gold has detected about 1 new digest(s) on patchset 3.
View them at https://flutter-engine-gold.skia.org/cl/github/36122

@skia-gold
Copy link

Gold has detected about 2 new digest(s) on patchset 4.
View them at https://flutter-engine-gold.skia.org/cl/github/36122

@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

Changes reported for pull request #36122 at sha 844dc1b

@mdebbar mdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 13, 2022
@auto-submit auto-submit bot merged commit dfc834c into flutter:main Sep 13, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 13, 2022
Oleh-Sv pushed a commit to Oleh-Sv/engine that referenced this pull request Sep 28, 2022
@mdebbar mdebbar deleted the duplicate_golden_methods branch January 17, 2023 18:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-web Code specifically for the web engine will affect goldens

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants