Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@chinmaygarde
Copy link
Contributor

This changes is part of a large patch for easier review. Try the whole patch in one go by checking out https://github.com/chinmaygarde/flutter_engine/tree/shell directly. This patch contains the following changes:

  • Unify snapshot symbol names across platforms and apply a GN format pass.

This changes is part of a large patch for easier review. Try the whole patch in one go by checking out https://github.com/chinmaygarde/flutter_engine/tree/shell directly. This patch contains the following changes:
* Unify snapshot symbol names across platforms and apply a GN format pass.
Copy link
Contributor

@rmacnak-google rmacnak-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbracken
Copy link
Member

lgtm

@chinmaygarde
Copy link
Contributor Author

Landed in #4932.

@chinmaygarde chinmaygarde deleted the flutter/lib/snapshot branch April 10, 2018 21:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants