Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 28 additions & 27 deletions lib/snapshot/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ if (is_fuchsia) {

dot_packages_file = "$target_gen_dir/snapshot.packages"
outputs = [
dot_packages_file
dot_packages_file,
]
deps = []
foreach(dep, dart_deps) {
Expand All @@ -43,26 +43,27 @@ if (is_fuchsia) {

script = "//build/dart/gen_dot_packages.py"
args = [
"--out",
rebase_path(dot_packages_file, root_build_dir),
"--source-dir",
rebase_path("."),
"--root-build-dir",
rebase_path(root_build_dir),
"--root-gen-dir",
rebase_path(dart_root_gen_dir),
"--package-name",
"snapshot_root",
"--depfile",
rebase_path(depfile),
"--deps",
] + dart_deps
"--out",
rebase_path(dot_packages_file, root_build_dir),
"--source-dir",
rebase_path("."),
"--root-build-dir",
rebase_path(root_build_dir),
"--root-gen-dir",
rebase_path(dart_root_gen_dir),
"--package-name",
"snapshot_root",
"--depfile",
rebase_path(depfile),
"--deps",
] + dart_deps
}
}

action("generate_snapshot_bin") {
if (is_fuchsia) {
snapshot_dart = "snapshot_fuchsia.dart"

# TODO(rmacnak): Fuchsia cross builds use the wrong Dart target
# architecture, and have added steps that depend on this error for
# reasonable build times (e.g., invoking the analyzer).
Expand Down Expand Up @@ -105,9 +106,9 @@ action("generate_snapshot_bin") {

rebased_dart_ui_path = rebase_path(dart_ui_path)

gen_snapshot_dir =
get_label_info("//third_party/dart/runtime/bin:gen_snapshot($host_toolchain)",
"root_out_dir")
gen_snapshot_dir = get_label_info(
"//third_party/dart/runtime/bin:gen_snapshot($host_toolchain)",
"root_out_dir")
script = "//third_party/dart/runtime/tools/create_snapshot_bin.py"

args = [
Expand Down Expand Up @@ -226,7 +227,7 @@ bin_to_assembly("isolate_snapshot_data_assembly") {
]
input = "$target_gen_dir/isolate_snapshot.bin"
output = "$target_gen_dir/isolate_snapshot_data.S"
symbol = "kDartIsolateCoreSnapshotData"
symbol = "kDartIsolateSnapshotData"
executable = false
}

Expand All @@ -236,7 +237,7 @@ bin_to_assembly("isolate_snapshot_instructions_assembly") {
]
input = "$target_gen_dir/isolate_snapshot_instructions.bin"
output = "$target_gen_dir/isolate_snapshot_instructions.S"
symbol = "kDartIsolateCoreSnapshotInstructions"
symbol = "kDartIsolateSnapshotInstructions"
executable = true
}

Expand Down Expand Up @@ -266,9 +267,9 @@ compile_platform("non_strong_platform") {
]

args = [
"--target=flutter",
"dart:core",
]
"--target=flutter",
"dart:core",
]
}

compile_platform("strong_platform") {
Expand All @@ -282,10 +283,10 @@ compile_platform("strong_platform") {
]

args = [
"--target=flutter",
"--strong",
"dart:core"
]
"--target=flutter",
"--strong",
"dart:core",
]
}

group("kernel_platform_files") {
Expand Down