This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Roll Skia from 12c8bd6ac1d9 to c1c8ff84997c (14 revisions) #56801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://skia.googlesource.com/skia.git/+log/12c8bd6ac1d9..c1c8ff84997c 2024-11-25 danieldilan@google.com Revert "Change window::DisplayParams to be immutable and passed by pointer" 2024-11-25 lukasza@chromium.org [rust png] Build / sources organization: Separate `decoder/` directory. 2024-11-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 73e40f43c062 to 64698c1a35b2 (1 revision) 2024-11-25 kjlubick@google.com Change window::DisplayParams to be immutable and passed by pointer 2024-11-25 danieldilan@google.com Use SkSafe32 functions when adding/subtracting deltas. 2024-11-25 kjlubick@google.com Save 16 bytes on GrContextOptions allocations* by reordering fields 2024-11-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from e4021a6fc9aa to 52028e548417 2024-11-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from 931df19ec335 to 9e05eb5b9edb 2024-11-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll shaders-base from 99b73d05cdae to 7bdb025e3cbb 2024-11-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from 034839b9814b to 99d4627f212e 2024-11-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from c0ad379b6c58 to e4021a6fc9aa 2024-11-25 kylechar@chromium.org Fix DefaultImageProvider::Make() leak 2024-11-25 kjlubick@google.com Make SkGlyph and GrDriverBugWorkarounds trivially destructible 2024-11-25 michaelludwig@google.com [graphite] Fix texture matrix for asyncReadPixelsYUV420 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC aaclarke@google.com,brianosman@google.com,danieldilan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
skia-flutter-autoroll
force-pushed
the
skia-flutter-autoroll-ad83daee-68bc-4c2b-86df-c51dabad3124-1732576691
branch
from
981f089 to
0a9bfb9
Compare
skia-flutter-autoroll
added
the
autosubmit
fluttergithubbot
approved these changes
Nov 25, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 26, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 26, 2024
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 26, 2024
flutter/engine@fe45a66...fb64399 2024-11-26 chris@bracken.jp iOS: Migrate PlatformViewsController to Objective-C (flutter/engine#56790) 2024-11-26 30870216+gaaclarke@users.noreply.github.com Started caching HandleGLES's hash and made them immutable (flutter/engine#56800) 2024-11-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[iOS] Full keyboard access scrolling (#56606)" (flutter/engine#56802) 2024-11-26 skia-flutter-autoroll@skia.org Roll Skia from 12c8bd6ac1d9 to c1c8ff84997c (14 revisions) (flutter/engine#56801) 2024-11-25 jonahwilliams@google.com [Impeller] better handle allocation herustics of Android slide in page transition. (flutter/engine#56762) 2024-11-25 chris@bracken.jp iOS: Eliminate logging of non-zero origin platformviews (flutter/engine#56796) 2024-11-25 30870216+gaaclarke@users.noreply.github.com [impeller] gles: started storing the number of handle deletions to avoid reallocation (flutter/engine#56799) 2024-11-25 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 9o0fWa2xVhmxV6Mtn... to 50xtjbMWWrqay_7m_... (flutter/engine#56795) 2024-11-25 skia-flutter-autoroll@skia.org Roll Dart SDK from df716eaa6ed2 to 4b49546a1dfa (1 revision) (flutter/engine#56793) 2024-11-25 31859944+LongCatIsLooong@users.noreply.github.com [iOS] Full keyboard access scrolling (flutter/engine#56606) 2024-11-25 jonahwilliams@google.com [android] remove fml_check from surface_texture_external_texture (flutter/engine#56760) 2024-11-25 30870216+gaaclarke@users.noreply.github.com removed unused variable for skia initialization (flutter/engine#56791) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 9o0fWa2xVhmx to 50xtjbMWWrqa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 26, 2024
…159461)" (#159498) <!-- start_original_pr_link --> Reverts: #159461 <!-- end_original_pr_link --> <!-- start_initiating_author --> Initiated by: yjbanov <!-- end_initiating_author --> <!-- start_revert_reason --> Reason for reverting: engine regression #159497 <!-- end_revert_reason --> <!-- start_original_pr_author --> Original PR Author: engine-flutter-autoroll <!-- end_original_pr_author --> <!-- start_reviewers --> Reviewed By: {fluttergithubbot} <!-- end_reviewers --> <!-- start_revert_body --> This change reverts the following previous change: flutter/engine@fe45a66...fb64399 2024-11-26 chris@bracken.jp iOS: Migrate PlatformViewsController to Objective-C (flutter/engine#56790) 2024-11-26 30870216+gaaclarke@users.noreply.github.com Started caching HandleGLES's hash and made them immutable (flutter/engine#56800) 2024-11-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[iOS] Full keyboard access scrolling (#56606)" (flutter/engine#56802) 2024-11-26 skia-flutter-autoroll@skia.org Roll Skia from 12c8bd6ac1d9 to c1c8ff84997c (14 revisions) (flutter/engine#56801) 2024-11-25 jonahwilliams@google.com [Impeller] better handle allocation herustics of Android slide in page transition. (flutter/engine#56762) 2024-11-25 chris@bracken.jp iOS: Eliminate logging of non-zero origin platformviews (flutter/engine#56796) 2024-11-25 30870216+gaaclarke@users.noreply.github.com [impeller] gles: started storing the number of handle deletions to avoid reallocation (flutter/engine#56799) 2024-11-25 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 9o0fWa2xVhmxV6Mtn... to 50xtjbMWWrqay_7m_... (flutter/engine#56795) 2024-11-25 skia-flutter-autoroll@skia.org Roll Dart SDK from df716eaa6ed2 to 4b49546a1dfa (1 revision) (flutter/engine#56793) 2024-11-25 31859944+LongCatIsLooong@users.noreply.github.com [iOS] Full keyboard access scrolling (flutter/engine#56606) 2024-11-25 jonahwilliams@google.com [android] remove fml_check from surface_texture_external_texture (flutter/engine#56760) 2024-11-25 30870216+gaaclarke@users.noreply.github.com removed unused variable for skia initialization (flutter/engine#56791) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 9o0fWa2xVhmx to 50xtjbMWWrqa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md <!-- end_revert_body --> Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 26, 2024
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 26, 2024
flutter/engine@fe45a66...bd165dc 2024-11-26 chris@bracken.jp Revert "iOS: Migrate PlatformViewsController to Objective-C (#56790)" (flutter/engine#56817) 2024-11-26 chris@bracken.jp iOS: Rename FlutterPlatformViews_Internal.mm (flutter/engine#56816) 2024-11-26 chris@bracken.jp iOS: Eliminate global in platformviews controller (flutter/engine#56805) 2024-11-26 skia-flutter-autoroll@skia.org Roll Skia from a276978ba7c8 to f149f852c70a (1 revision) (flutter/engine#56812) 2024-11-26 skia-flutter-autoroll@skia.org Roll Skia from d7a267d88fd6 to a276978ba7c8 (1 revision) (flutter/engine#56811) 2024-11-26 skia-flutter-autoroll@skia.org Roll Skia from 8d9d892657a7 to d7a267d88fd6 (1 revision) (flutter/engine#56810) 2024-11-26 skia-flutter-autoroll@skia.org Roll Dart SDK from bdb76c714009 to ca02d403f1a8 (1 revision) (flutter/engine#56809) 2024-11-26 skia-flutter-autoroll@skia.org Roll Skia from b697dd1b03b2 to 8d9d892657a7 (1 revision) (flutter/engine#56808) 2024-11-26 skia-flutter-autoroll@skia.org Roll Skia from c1c8ff84997c to b697dd1b03b2 (1 revision) (flutter/engine#56807) 2024-11-26 chris@bracken.jp iOS: Delete FlutterPlatformViewsController.layerPoolSize (flutter/engine#56806) 2024-11-26 skia-flutter-autoroll@skia.org Roll Dart SDK from 4b49546a1dfa to bdb76c714009 (1 revision) (flutter/engine#56803) 2024-11-26 chris@bracken.jp iOS: Migrate PlatformViewsController to Objective-C (flutter/engine#56790) 2024-11-26 30870216+gaaclarke@users.noreply.github.com Started caching HandleGLES's hash and made them immutable (flutter/engine#56800) 2024-11-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[iOS] Full keyboard access scrolling (#56606)" (flutter/engine#56802) 2024-11-26 skia-flutter-autoroll@skia.org Roll Skia from 12c8bd6ac1d9 to c1c8ff84997c (14 revisions) (flutter/engine#56801) 2024-11-25 jonahwilliams@google.com [Impeller] better handle allocation herustics of Android slide in page transition. (flutter/engine#56762) 2024-11-25 chris@bracken.jp iOS: Eliminate logging of non-zero origin platformviews (flutter/engine#56796) 2024-11-25 30870216+gaaclarke@users.noreply.github.com [impeller] gles: started storing the number of handle deletions to avoid reallocation (flutter/engine#56799) 2024-11-25 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 9o0fWa2xVhmxV6Mtn... to 50xtjbMWWrqay_7m_... (flutter/engine#56795) 2024-11-25 skia-flutter-autoroll@skia.org Roll Dart SDK from df716eaa6ed2 to 4b49546a1dfa (1 revision) (flutter/engine#56793) 2024-11-25 31859944+LongCatIsLooong@users.noreply.github.com [iOS] Full keyboard access scrolling (flutter/engine#56606) 2024-11-25 jonahwilliams@google.com [android] remove fml_check from surface_texture_external_texture (flutter/engine#56760) 2024-11-25 30870216+gaaclarke@users.noreply.github.com removed unused variable for skia initialization (flutter/engine#56791) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 9o0fWa2xVhmx to 50xtjbMWWrqa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
skia-flutter-autoroll
deleted the
skia-flutter-autoroll-ad83daee-68bc-4c2b-86df-c51dabad3124-1732576691
branch
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…ngine#56801) https://skia.googlesource.com/skia.git/+log/12c8bd6ac1d9..c1c8ff84997c 2024-11-25 danieldilan@google.com Revert "Change window::DisplayParams to be immutable and passed by pointer" 2024-11-25 lukasza@chromium.org [rust png] Build / sources organization: Separate `decoder/` directory. 2024-11-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 73e40f43c062 to 64698c1a35b2 (1 revision) 2024-11-25 kjlubick@google.com Change window::DisplayParams to be immutable and passed by pointer 2024-11-25 danieldilan@google.com Use SkSafe32 functions when adding/subtracting deltas. 2024-11-25 kjlubick@google.com Save 16 bytes on GrContextOptions allocations* by reordering fields 2024-11-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from e4021a6fc9aa to 52028e548417 2024-11-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from 931df19ec335 to 9e05eb5b9edb 2024-11-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll shaders-base from 99b73d05cdae to 7bdb025e3cbb 2024-11-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from 034839b9814b to 99d4627f212e 2024-11-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from c0ad379b6c58 to e4021a6fc9aa 2024-11-25 kylechar@chromium.org Fix DefaultImageProvider::Make() leak 2024-11-25 kjlubick@google.com Make SkGlyph and GrDriverBugWorkarounds trivially destructible 2024-11-25 michaelludwig@google.com [graphite] Fix texture matrix for asyncReadPixelsYUV420 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC aaclarke@google.com,brianosman@google.com,danieldilan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://skia.googlesource.com/skia.git/+log/12c8bd6ac1d9..c1c8ff84997c
2024-11-25 danieldilan@google.com Revert "Change window::DisplayParams to be immutable and passed by pointer"
2024-11-25 lukasza@chromium.org [rust png] Build / sources organization: Separate
decoder/directory.2024-11-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 73e40f43c062 to 64698c1a35b2 (1 revision)
2024-11-25 kjlubick@google.com Change window::DisplayParams to be immutable and passed by pointer
2024-11-25 danieldilan@google.com Use SkSafe32 functions when adding/subtracting deltas.
2024-11-25 kjlubick@google.com Save 16 bytes on GrContextOptions allocations* by reordering fields
2024-11-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from e4021a6fc9aa to 52028e548417
2024-11-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll debugger-app-base from 931df19ec335 to 9e05eb5b9edb
2024-11-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll shaders-base from 99b73d05cdae to 7bdb025e3cbb
2024-11-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll jsfiddle-base from 034839b9814b to 99d4627f212e
2024-11-25 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skottie-base from c0ad379b6c58 to e4021a6fc9aa
2024-11-25 kylechar@chromium.org Fix DefaultImageProvider::Make() leak
2024-11-25 kjlubick@google.com Make SkGlyph and GrDriverBugWorkarounds trivially destructible
2024-11-25 michaelludwig@google.com [graphite] Fix texture matrix for asyncReadPixelsYUV420
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-flutter-autoroll
Please CC aaclarke@google.com,brianosman@google.com,danieldilan@google.com on the revert to ensure that a human
is aware of the problem.
To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md