This repository was archived by the owner on Feb 25, 2025. It is now read-only.
iOS: Delete FlutterPlatformViewsController.layerPoolSize #56806
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This field is unused in the codebase/tests.
hellohuanlin
approved these changes
Nov 26, 2024
cbracken
added
the
autosubmit
8 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Nov 26, 2024
…#56817) This is a combination of 3 reverts, required to get back to the revert that caused `ios_platform_view_tests` to start failing in the framework repo. In reverse chronological order, this reverts two trivial commits plus the non-trivial commit that likely caused the breakage: * Revert "iOS: Eliminate global in platformviews controller (#56805)" This reverts commit 752e2d7. * Revert "iOS: Delete FlutterPlatformViewsController.layerPoolSize (#56806)" This reverts commit 21c655c. * Revert "iOS: Migrate PlatformViewsController to Objective-C (#56790)" This reverts commit fb64399. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 26, 2024
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 26, 2024
flutter/engine@fe45a66...bd165dc 2024-11-26 chris@bracken.jp Revert "iOS: Migrate PlatformViewsController to Objective-C (#56790)" (flutter/engine#56817) 2024-11-26 chris@bracken.jp iOS: Rename FlutterPlatformViews_Internal.mm (flutter/engine#56816) 2024-11-26 chris@bracken.jp iOS: Eliminate global in platformviews controller (flutter/engine#56805) 2024-11-26 skia-flutter-autoroll@skia.org Roll Skia from a276978ba7c8 to f149f852c70a (1 revision) (flutter/engine#56812) 2024-11-26 skia-flutter-autoroll@skia.org Roll Skia from d7a267d88fd6 to a276978ba7c8 (1 revision) (flutter/engine#56811) 2024-11-26 skia-flutter-autoroll@skia.org Roll Skia from 8d9d892657a7 to d7a267d88fd6 (1 revision) (flutter/engine#56810) 2024-11-26 skia-flutter-autoroll@skia.org Roll Dart SDK from bdb76c714009 to ca02d403f1a8 (1 revision) (flutter/engine#56809) 2024-11-26 skia-flutter-autoroll@skia.org Roll Skia from b697dd1b03b2 to 8d9d892657a7 (1 revision) (flutter/engine#56808) 2024-11-26 skia-flutter-autoroll@skia.org Roll Skia from c1c8ff84997c to b697dd1b03b2 (1 revision) (flutter/engine#56807) 2024-11-26 chris@bracken.jp iOS: Delete FlutterPlatformViewsController.layerPoolSize (flutter/engine#56806) 2024-11-26 skia-flutter-autoroll@skia.org Roll Dart SDK from 4b49546a1dfa to bdb76c714009 (1 revision) (flutter/engine#56803) 2024-11-26 chris@bracken.jp iOS: Migrate PlatformViewsController to Objective-C (flutter/engine#56790) 2024-11-26 30870216+gaaclarke@users.noreply.github.com Started caching HandleGLES's hash and made them immutable (flutter/engine#56800) 2024-11-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[iOS] Full keyboard access scrolling (#56606)" (flutter/engine#56802) 2024-11-26 skia-flutter-autoroll@skia.org Roll Skia from 12c8bd6ac1d9 to c1c8ff84997c (14 revisions) (flutter/engine#56801) 2024-11-25 jonahwilliams@google.com [Impeller] better handle allocation herustics of Android slide in page transition. (flutter/engine#56762) 2024-11-25 chris@bracken.jp iOS: Eliminate logging of non-zero origin platformviews (flutter/engine#56796) 2024-11-25 30870216+gaaclarke@users.noreply.github.com [impeller] gles: started storing the number of handle deletions to avoid reallocation (flutter/engine#56799) 2024-11-25 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 9o0fWa2xVhmxV6Mtn... to 50xtjbMWWrqay_7m_... (flutter/engine#56795) 2024-11-25 skia-flutter-autoroll@skia.org Roll Dart SDK from df716eaa6ed2 to 4b49546a1dfa (1 revision) (flutter/engine#56793) 2024-11-25 31859944+LongCatIsLooong@users.noreply.github.com [iOS] Full keyboard access scrolling (flutter/engine#56606) 2024-11-25 jonahwilliams@google.com [android] remove fml_check from surface_texture_external_texture (flutter/engine#56760) 2024-11-25 30870216+gaaclarke@users.noreply.github.com removed unused variable for skia initialization (flutter/engine#56791) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from 9o0fWa2xVhmx to 50xtjbMWWrqa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
8 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Nov 27, 2024
) This field is unused in the codebase/tests. This is a reland of #56806, which was reverted as part of #56790. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…ine#56806) This field is unused in the codebase/tests. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…tter/engine#56830) This field is unused in the codebase/tests. This is a reland of flutter/engine#56806, which was reverted as part of flutter/engine#56790. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This field is unused in the codebase/tests.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.