This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Build windows engine on GCE #8442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gspencergoog
approved these changes
Apr 4, 2019
Contributor
gspencergoog
left a comment
gspencergoog
left a comment
There was a problem hiding this comment.
Cool, thanks for setting that up!
dnfield
approved these changes
Apr 4, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 4, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 4, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 5, 2019
liyuqian
added a commit
that referenced
this pull request
Apr 5, 2019
Have this script reviewed and committed to our repo for our future reference. This prepares the VM used in #8442 Once our Docker container is tested in GKE (after Kubernetes 1.14 is ready), I'll also upload Dockefiles and its related scripts here.
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 5, 2019
flutter/engine@219bf59...8b74cba git log 219bf59..8b74cba --no-merges --oneline 8b74cba Make sure FlutterViewController flushs all pending touches when no longer active (flutter/engine#8400) 06cab81 Roll src/third_party/skia e4628b10722f..51874e3e3712 (2 commits) (flutter/engine#8445) 5460926 Roll src/third_party/dart 9814cb1b9c..896f1c4bb9 (4 commits) 694fc56 Build windows engine on GCE (flutter/engine#8442) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop the roller if necessary.
RBogie
pushed a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
This allows us to test windows engine compilation in presubmit checks using our own 32-CPU GCE instance for less than 10 minutes.
RBogie
pushed a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
Have this script reviewed and committed to our repo for our future reference. This prepares the VM used in flutter#8442 Once our Docker container is tested in GKE (after Kubernetes 1.14 is ready), I'll also upload Dockefiles and its related scripts here.
RBogie
added a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
This reverts commit 949f425.
RBogie
added a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
This reverts commit 949f425.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to test windows engine compilation in presubmit checks using our own 32-CPU GCE instance for less than 10 minutes.