This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add scripts that prepares our windows VM image #8446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liyuqian
force-pushed
the
windows_vm_prepare
branch
from
89c796e to
4e66ade
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 5, 2019
digiter
reviewed
Apr 5, 2019
| curl https://raw.githubusercontent.com/flutter/engine/master/ci/docker/build/engine_gclient ` | ||
| -o c:/flutter/engine/.gclient | ||
|
|
||
| # Once all the environment variables above are loaded correctly, one may test |
There was a problem hiding this comment.
It's better to tell the user what to do next at the end. In this script, probably add:
- This script finished successfully.
- A reboot of the terminal (or VM) is required for environment variables to be effective.
- After rebooting, run the following commands to test build the engine.
Contributor
There was a problem hiding this comment.
I think thi scomment is in reference to the state of the container rather than what the user should be doing at this point...
Contributor
Author
There was a problem hiding this comment.
Thanks Tong and Dan for the comments! I think both of you are kind of correct: the steps that Tong mentioned are the next steps someone would do to test the correctness of the image; on the other hand, one can directly make an image without doing the test, so those next steps are optional.
I'll create another PR to add comments to clarify this. We can discuss there until it's clear what this script is doing and how someone should use it.
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Apr 5, 2019
…e#8446) (#30538) flutter/engine@8b74cba...697e541 git log 8b74cba..697e541 --no-merges --oneline 697e541 Add scripts that prepares our windows VM image (flutter/engine#8446) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop the roller if necessary.
RBogie
pushed a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
Have this script reviewed and committed to our repo for our future reference. This prepares the VM used in flutter#8442 Once our Docker container is tested in GKE (after Kubernetes 1.14 is ready), I'll also upload Dockefiles and its related scripts here.
RBogie
added a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
This reverts commit 79e2b62.
RBogie
added a commit
to RBogie/flutter-engine
that referenced
this pull request
Apr 8, 2019
This reverts commit 79e2b62.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to have this script reviewed and committed to our repo for our future reference.
This prepares the VM used in #8442
Once our Docker container is tested in GKE (after Kubernetes 1.14 is ready), I'll also upload Dockefiles and its related scripts here.