This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[webview_flutter] Move the method channel behind the platform interface #1645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@nkoroste please take a look |
cyanglaz
reviewed
May 30, 2019
Contributor
cyanglaz
left a comment
cyanglaz
left a comment
There was a problem hiding this comment.
Overall approach looks good, left some comments.
| } | ||
|
|
||
| @override | ||
| Future<void> goBack() async { |
Contributor
There was a problem hiding this comment.
optional nit:
`Future goBack() =>_channel.invokeMethod("goBack");
Same for others.
Also, we prod don't need the async mark in the method signature if we keep this style.
| Future<void> loadUrl( | ||
| String url, { | ||
| Map<String, String> headers, | ||
| }) async { |
Contributor
There was a problem hiding this comment.
do we need the async here?
amirh
added a commit
that referenced
this pull request
May 31, 2019
This is a followup for #1618, #1624, and #1645, and moves the plugins.flutter.io/cookie_manager method channel behind the platform interface which allows a third party package to provide a new platform implementation the cooke manager. See the description for #1618 for more details. Following this PR all platform specific code can be replaced by an external package.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup for #1618 and #1624, and moves all of the
plugins.flutter.io/webviewmethod channel calls behind the platform interface, which allows a third party package to provide a new platform implementation for all of these methods.See the description for #1618 for more details.
The last remaining part is the
plugins.flutter.io/cookie_managerchannel which I'm leaving for a followup PR.