This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Move clearCookies behind the platform abstraction #1663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkoroste
approved these changes
May 31, 2019
nkoroste
left a comment
nkoroste
left a comment
There was a problem hiding this comment.
Overall LGTM, I think we should get it in to unblock Fuchsia first. Then during the Fuchsia implementation we can iterate on the naming some more.
|
|
||
| typedef WebViewPlatformCreatedCallback = void Function( | ||
| WebViewPlatform webViewPlatform); | ||
| WebViewPlatformController webViewPlatform); |
There was a problem hiding this comment.
Suggested change
| WebViewPlatformController webViewPlatform); | |
| WebViewPlatformController webViewPlatformController); |
| /// The default value is [AndroidWebViewBuilder] on Android and [CupertinoWebViewBuilder] on iOs. | ||
| static set platformBuilder(WebViewBuilder platformBuilder) { | ||
| _platformBuilder = platformBuilder; | ||
| /// The default value is [AndroidWebView] on Android and [CupertinoWebView] on iOs. |
There was a problem hiding this comment.
Suggested change
| /// The default value is [AndroidWebView] on Android and [CupertinoWebView] on iOs. | |
| /// The default value is [AndroidWebView] on Android and [CupertinoWebView] on iOS. |
| static set platformBuilder(WebViewBuilder platformBuilder) { | ||
| _platformBuilder = platformBuilder; | ||
| /// The default value is [AndroidWebView] on Android and [CupertinoWebView] on iOs. | ||
| static set platform(WebViewPlatform platformBuilder) { |
There was a problem hiding this comment.
Suggested change
| static set platform(WebViewPlatform platformBuilder) { | |
| static set platform(WebViewPlatform platform) { |
| _platformBuilder = platformBuilder; | ||
| /// The default value is [AndroidWebView] on Android and [CupertinoWebView] on iOs. | ||
| static set platform(WebViewPlatform platformBuilder) { | ||
| _platform = platformBuilder; |
There was a problem hiding this comment.
Suggested change
| _platform = platformBuilder; | |
| _platform = platform; |
| } | ||
|
|
||
| final WebViewPlatform _webViewPlatform; | ||
| final WebViewPlatformController _webViewPlatform; |
There was a problem hiding this comment.
Suggested change
| final WebViewPlatformController _webViewPlatform; | |
| final WebViewPlatformController _webViewPlatformController; |
| } | ||
|
|
||
| class MyWebViewBuilder implements WebViewBuilder { | ||
| class MyWebViewBuilder implements WebViewPlatform { |
There was a problem hiding this comment.
Suggested change
| class MyWebViewBuilder implements WebViewPlatform { | |
| class MyWebViewPlatform implements WebViewPlatform { |
| ); | ||
|
|
||
| final MyWebViewBuilder builder = WebView.platformBuilder; | ||
| final MyWebViewBuilder builder = WebView.platform; |
There was a problem hiding this comment.
Suggested change
| final MyWebViewBuilder builder = WebView.platform; | |
| final MyWebViewPlatform builder = WebView.platform; |
| ); | ||
|
|
||
| final MyWebViewBuilder builder = WebView.platformBuilder; | ||
| final MyWebViewBuilder builder = WebView.platform; |
There was a problem hiding this comment.
Suggested change
| final MyWebViewBuilder builder = WebView.platform; | |
| final MyWebViewPlatform builder = WebView.platform; |
| } | ||
|
|
||
| class MyWebViewPlatform extends WebViewPlatform { | ||
| class MyWebViewPlatform extends WebViewPlatformController { |
There was a problem hiding this comment.
Suggested change
| class MyWebViewPlatform extends WebViewPlatformController { | |
| class MyWebViewPlatformController extends WebViewPlatformController { |
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
…ror". (flutter#1663) (flutter#1665) * Updates the example with the missing "recordError". (flutter#1663)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup for #1618, #1624, and #1645, and moves the
plugins.flutter.io/cookie_managermethod channel behind the platform interface which allows a third party package to provide a new platform implementation the cooke manager.See the description for #1618 for more details.
Following this PR all platform specific code can be replaced by an external package.
Note on renamed classes
Before this PR we had a
WebViewBuilderclass(which had the build method) and aWebViewPlatformclass (which abstracted what's currently done on the webview method channel).A
WebViewPlatforminstance existed perWebViewinstance, andWebViewBuilderneeds to exist once.As
clearCookiesis not associated with aWebViewinstance I added it to what was previously namedWebViewBuilderand renamed both classes:WebViewPlatform->WebViewPlatformControllerWebViewBuilder->WebViewPlatformWith this, to replace the platform implementation you do
WebView.platform = FuchsiaWebView();.I'm far from being in love with the current names, and happy to do something else (we haven't published the plugin yet so this isn't a breaking change yet).
An alternative option I have in mind is to add a separate
CookieManagerPlatforminterface (this will mean we have to not only doWebView.platformBuilder = FuchsiaWebViewBuilder()but alsoCookieManager.platform = FuchsiaCookieManager().@nkoroste, @cyanglaz any thouhgs?
@Hixie you had opinions on these names in #1618, curious to see what you think.