Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Update GMS to 11.+ #229

Merged
collinjackson merged 4 commits into from
Oct 17, 2017
Merged

Update GMS to 11.+ #229

collinjackson merged 4 commits into from
Oct 17, 2017

Conversation

@collinjackson
Copy link
Contributor

@collinjackson collinjackson commented Oct 3, 2017 •
edited
Loading

This should allow us to be compatible with new functionality like Firestore without having to rev every plugin when a new API is introduced.

Fixes flutter/flutter#12399

goderbauer
goderbauer approved these changes Oct 3, 2017
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced Oct 8, 2017
Closed
Open
@zh4ngx
Copy link

zh4ngx commented Oct 10, 2017

We're excited to try out Firestore and awaiting this merge @pcomans

@collinjackson
Copy link
Contributor Author

collinjackson commented Oct 10, 2017

Sorry I got tied up merging this, I'll try to get to it landed soon.

@mit-mit
Copy link
Member

mit-mit commented Oct 11, 2017

@collinjackson I fixed the merge conflict, please check

@mit-mit mit-mit mentioned this pull request Oct 13, 2017
Closed
@googlebot
Copy link

googlebot commented Oct 17, 2017

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

mogol and others added 2 commits October 17, 2017 16:28
@mogol @collinjackson
Fix firebase_auth warnings (flutter#233)
e565fff 
* Update firebase_auth deprecated api

* Suppress unchecked warning in firebase_database

* Update example for firebase_auth

* Fix iOS warnings

* Updated pubspec.yaml and CHANGELOG
@collinjackson
Update firebase_analytics
3baf25f
@collinjackson collinjackson merged commit f858d21 into flutter:master Oct 17, 2017
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
@collinjackson
Update GMS to 11.+ (flutter#229)
2760c67
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@goderbauer goderbauer goderbauer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: no

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@collinjackson @zh4ngx @mit-mit @googlebot @goderbauer @mogol