Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@tafelito
Copy link

@tafelito tafelito commented Mar 5, 2020

Description

If you scrub video on iOS while paused the player does not update the frames. This PR fixes that issue

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I updated/added relevant documentation (doc comments with ///).
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@tafelito
Copy link
Author

tafelito commented Mar 5, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Mar 5, 2020
@cbenhagen
Copy link
Contributor

Thank you for your contribution! #2397 would actually be a better fix for this as it will only update the texture when you really seek. The only missing parts to merge the mentioned PR is the test. So if you have time it would be awesome if you could contribute one.

@dthuering
Copy link

Will this PR or #2397 merge in the near future? Waiting for this to work on iOS.

mciekurs2 pushed a commit to mciekurs2/plugins that referenced this pull request Jan 12, 2021
@stuartmorgan-g
Copy link
Contributor

Thanks for the contribution! I'm closing this in favor of #2758 per the discussion above just so we have a single PR to track; if you have issues with the approach there, please leave comments there for discussion.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants