[video_player] Fixed HLS streams on iOS (#48760)

[danielroek]

Description

Implements the changes of #1743 with the desired changes to the implementation. This makes it possible (again) to stream HLS stream with an indefinite length.

On an iPhone simulator I only hear the audio when playing a HLS stream, but running it on an iPad everything works.

I added some checks to the VideoProgressIndicator. On iOS, because the duration is 0, it's going to divide 0 by 0, which results in a crash. This is not an issue in Android. On iOS the ProgressIndicator now just shows no progress, which I believe should be the desired behaviour.

Related Issues

#1743
Fixes #48670

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
• All existing and new tests are passing.
• I updated/added relevant documentation (doc comments with ///).
• The analyzer (flutter analyze) does not report any problems on my PR.
• I read and followed the Flutter Style Guide.
• The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
• I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
• I updated CHANGELOG.md to add a description of the change.
• I signed the CLA.
• I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

• Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
• No, this is not a breaking change.

[mvanbeusekom]

Rebase with master and resolve conflicting version number

[danielroek]

Rebase with master and resolve conflicting version number

@mvanbeusekom Done

[amirh]

Thanks! left a few comments

[amirh]

Is it possible to cover the crashy behavior with a test?

[amirh]

Does duration 0 means it's indefinite? if so should we use null for value to show an indefinite progress indicator?

[danielroek]

It's 0 on iOS. Android returns different values

[amirh]

Do we have an indication on Android that it's indefinite? what does the progress bar show for indefinite streams on Android?

[danielroek]

The exoPlayer does have a isDynamic function on the Window. This is set to true when a Live stream is being played. I believe this would be the best solution. Link to the docs..

I could implement a VideoPlayerController().isDurationIndefinite getter that returns true when ExoPlayer returns true on the isDynamic getter on Android, and when isDurationIndefinite returns true on iOS?

[amirh]

@cyanglaz any hints on how to test cover this?