This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Import video player #280
Merged
Import video player #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mravn-google
approved these changes
Nov 27, 2017
| @@ -0,0 +1,160 @@ | |||
| #!/usr/bin/env bash | |||
Contributor
There was a problem hiding this comment.
Repo should not include the gradlew scripts nor gradle-wrapper.jar binary.
| result.success(player.getPosition()); | ||
| } else if (call.method.equals("dispose")) { | ||
| player.dispose(); | ||
| result.success(null ); |
| player.setLooping((Boolean) call.argument("looping")); | ||
| result.success(null); | ||
| } else if (call.method.equals("setVolume")) { | ||
| player.setVolume((Double)call.argument("volume")); |
Contributor
There was a problem hiding this comment.
Add space after cast.
| } | ||
|
|
||
| void setVolume(double value) { | ||
| float bracketedValue = (float)Math.max(0.0, Math.min(1.0, value)); |
Contributor
There was a problem hiding this comment.
At space after cast (three times).
| @@ -0,0 +1,160 @@ | |||
| #!/usr/bin/env bash | |||
Contributor
There was a problem hiding this comment.
Downloaded Gradle artifacts should be removed from here too.
| [_players removeObjectForKey:@(textureId)]; | ||
| [player dispose]; | ||
| } else if ([@"setLooping" isEqualToString:call.method]) { | ||
| [player setIsLooping:[argsMap objectForKey:@"looping"]]; |
Contributor
There was a problem hiding this comment.
Please adjust indentation. Here and elsewhere in ObjC code.
Member
|
Please also look at the travis issues. |
Review: cleanup and formatting
Update README.md
Fix platform bugs
Pause video when app goes in background
Add scrubbing
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import the video player into the flutter/plugins repo