Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Conversation

@liorboyango
Copy link

Added tileProvider to TileOverlay#copyWith - this fixes tileProvider not being cloned inside the TileOverlay object, which broke the TileOverlay;

Fixed a runtime cast exception in the example tile_overlay.dart;

Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.

List which issues are fixed by this PR. You must list at least one issue.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

…not being cloned inside the TileOverlay object, which broke the TileOverlay;

Fixed a runtime cast exception in the example tile_overlay.dart;
@liorboyango liorboyango requested a review from cyanglaz as a code owner March 12, 2021 10:09
@google-cla
Copy link

google-cla bot commented Mar 12, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@liorboyango
Copy link
Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Mar 12, 2021
@stuartmorgan-g
Copy link
Contributor

Thanks for the contribution! Please work through the checklist on the PR template, as this change is missing a number of the things laid out there (tests, issue link, CHANGELOG and version update). Once you've done that this can be reviewed.

@stuartmorgan-g
Copy link
Contributor

Since there's been no activity on addressing the comment above, I've fixed this in #3771. Closing in favor of that. Thanks again for the clear issue report and root-causing!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants