Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[google_maps_flutter] TileOverlay fix - null tileProvider caused TileOverlay to not be displayed on the map #3706

Closed
liorboyango wants to merge 3 commits into from
Closed

[google_maps_flutter] TileOverlay fix - null tileProvider caused TileOverlay to not be displayed on the map #3706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
21d47f7
Added tileProvider to TileOverlay#copyWith - this fixes tileProvider …
liorboyango Mar 12, 2021
0e6b8f5
Use commit 21d47f7;
liorboyango Mar 12, 2021
5986f0f
Reverted last commit;
liorboyango Mar 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/google_maps_flutter/google_maps_flutter/example/lib/tile_overlay.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,8 @@ class TileOverlayBodyState extends State<TileOverlayBody> {

@override
Widget build(BuildContext context) {
Set<TileOverlay?> overlays = <TileOverlay?>{
if (_tileOverlay != null) _tileOverlay,
Set<TileOverlay> overlays = <TileOverlay>{
if (_tileOverlay != null) _tileOverlay!,
};
return Column(
mainAxisSize: MainAxisSize.min,
Expand All @@ -84,7 +84,7 @@ class TileOverlayBodyState extends State<TileOverlayBody> {
target: LatLng(59.935460, 30.325177),
zoom: 7.0,
),
tileOverlays: overlays as Set<TileOverlay>,
tileOverlays: overlays,
onMapCreated: _onMapCreated,
),
),
Expand Down
2 changes: 2 additions & 0 deletions ...oogle_maps_flutter/google_maps_flutter_platform_interface/lib/src/types/tile_overlay.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ class TileOverlay implements MapsObject {
/// unless overwritten by the specified parameters.
TileOverlay copyWith({
bool? fadeInParam,
TileProvider? tileProviderParam,
double? transparencyParam,
int? zIndexParam,
bool? visibleParam,
Expand All @@ -99,6 +100,7 @@ class TileOverlay implements MapsObject {
return TileOverlay(
tileOverlayId: tileOverlayId,
fadeIn: fadeInParam ?? fadeIn,
tileProvider: tileProviderParam ?? tileProvider,
transparency: transparencyParam ?? transparency,
zIndex: zIndexParam ?? zIndex,
visible: visibleParam ?? visible,
Expand Down