Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Null safety broken for method isMarkerInfoWindowShown #78426 #3724

Closed
stefalda wants to merge 3 commits into from
Closed

Null safety broken for method isMarkerInfoWindowShown #78426 #3724

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4aa7775
Null safety broken for method isMarkerInfoWindowShown #78426
stefalda Mar 17, 2021
90247d5
Update method_channel_google_maps_flutter.dart
stefalda Mar 18, 2021
34a2755
Updated version and changelog
Mar 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/google_maps_flutter/google_maps_flutter/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## 2.0.2

* Fix null-safety annotation when calling isMarkerInfoWindowShown, because the code generated by
the migration tool gave an error relative to the method signature.

## 2.0.1

* Update platform_plugin_interface version requirement.
Expand Down
2 changes: 1 addition & 1 deletion packages/google_maps_flutter/google_maps_flutter/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: google_maps_flutter
description: A Flutter plugin for integrating Google Maps in iOS and Android applications.
homepage: https://github.com/flutter/plugins/tree/master/packages/google_maps_flutter/google_maps_flutter
version: 2.0.1
version: 2.0.2
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g Mar 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I hadn't looked at this closely enough; you've updated the version and changelog of the app-facing package, rather than the platform interface package where you made the change. You need to update the version of the package that your changes are in.


dependencies:
flutter:
Expand Down
6 changes: 3 additions & 3 deletions ...flutter_platform_interface/lib/src/method_channel/method_channel_google_maps_flutter.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,10 +414,10 @@ class MethodChannelGoogleMapsFlutter extends GoogleMapsFlutterPlatform {
Future<bool> isMarkerInfoWindowShown(
MarkerId markerId, {
required int mapId,
}) {
}) async {
assert(markerId != null);
return channel(mapId).invokeMethod<bool>('markers#isInfoWindowShown',
<String, String>{'markerId': markerId.value}) as Future<bool>;
return (await channel(mapId).invokeMethod<bool>('markers#isInfoWindowShown',
<String, String>{'markerId': markerId.value}))! ;
}

@override
Expand Down