Null safety broken for method isMarkerInfoWindowShown #78426

[stefalda]

The method isMarkerInfoWindowShown in file method_channel_google_maps_flutter.dart isn't working with null safety because the channel(mapId).invokeMethod has an optional return type (<T?>), so forcing it to bool doesn't work.

In the original code a cast has been added to silence the compiler warnings but there is a runtime error when the method is invoked because the signature invokeMethod should be invokeMethod<bool?>.

This is a fix for issue 78426 where there's the original code.

[google-cla]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[stefalda]

@googlebot I signed it!

[stuartmorgan-g]

Interesting, this was generated by the migration tool; I wonder why it generated that. Thanks for the contribution!

Please add a test that exercises this codepath (i.e., that fails without your fix and passes with it) per Flutter PR policy and the PR template checklist. This will also need a version and CHANGELOG update per the checklist (in the future, please don't delete the checklist when opening a PR; it's there to help smooth the process).

[google-cla]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

[stefalda]

@googlebot I fixed it

[google-cla]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

[stuartmorgan-g]

Thanks for the version update! Are you planning on adding the test coverage as well, or do you need feedback on something first?

[ditman]

Missing CLA for M@tilde07, not sure what commit triggered that.

[stefalda]

Missing CLA for M@tilde07, not sure what commit triggered that.

Sincerely I don't understand either, I was surprised it asked me to sign the CLA again...

[stefalda]

Thanks for the version update! Are you planning on adding the test coverage as well, or do you need feedback on something first?

I've tried but I've not been able to find the right test where to put the logic, because most of the tests use a fakeGoogleMap instead of the real one, so I'm unable to reproduce the problem that I've discovered while building a real app...

[stuartmorgan-g]

Missing CLA for M@tilde07, not sure what commit triggered that.

Sincerely I don't understand either, I was surprised it asked me to sign the CLA again...

The "Updated version and changelog" commit appears to be using a different email address; notice that it doesn't have your profile image. You probably need to ammend that commit locally to use this account's email address, and then force push.

[stuartmorgan-g]

Sorry, I hadn't looked at this closely enough; you've updated the version and changelog of the app-facing package, rather than the platform interface package where you made the change. You need to update the version of the package that your changes are in.

[stuartmorgan-g]

Thanks for the version update! Are you planning on adding the test coverage as well, or do you need feedback on something first?

I've tried but I've not been able to find the right test where to put the logic, because most of the tests use a fakeGoogleMap instead of the real one, so I'm unable to reproduce the problem that I've discovered while building a real app...

The test should go in this group. Currently there are no realy tests there it looks like (just a placeholder that should be removed), but you can look at, e.g., this to see what a test that sets mock method channel data looks like.

[hlavki]

@stefalda can be this problem related also to issue #78856? thanks

[stefalda]

@stefalda can be this problem related also to issue #78856? thanks

Yes, I guess that it could be the same problem just in another method call

[stuartmorgan-g]

Since this is a more general problem, I'll follow up shortly with a PR that tests all of the APIs that could have this issue, and fixes all of them, which will replace this one.

[stuartmorgan-g]

Closing in favor of #3754. Thanks for the clear issue report, debugging, and PR, which definitely accelerated the fix here!