This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[google_maps_flutter] Fix handling of non-nullable invokeMethod return types #3754
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the null-safety migration I accepted the auto-migrator use of
as Future<T>to handleinvokeMethod<T>returning aT?. I didn't realize thatasdoes not actually do that kind of casting, and will fail withtype 'Future<T?>' is not a subtype of type 'Future<T>' in type cast.There were no tests that exercised these methods in any way, so automated tests didn't catch the bug. This adds a minimal test that calls all of the non-void methods to ensure that they don't explode (and a TODO to backfill full unit tests of the entire method channel).
Fixes flutter/flutter#78426
Fixes flutter/flutter#78856
Pre-launch Checklist
[shared_preferences]///).