This repository was archived by the owner on Feb 22, 2023. It is now read-only.
[image_picker] R8 bug workaround #3766
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#78625
I reported this bug to the R8 team as there was some recent work in this area.
Currently, importing
ImagePickerPlugincauses the outer method code to be removed:Changing the APIs consumed in
ImagePickerPlugincauses different R8 optimizations. Particularly, theonDestroymethod seems suspicious. https://gist.github.com/blasten/aad37e8173f6c52cc7c0d4ce403aa1e2.For testing this, we would need an e2e test that builds release, and calls the methods in the channel. Unfortunately, these type of e2e tests typically live in the framework, so it would need to be defined there.
Pre-launch Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.