This repository was archived by the owner on Feb 22, 2023. It is now read-only.
Make sure androidx.lifecycle classes aren't R8'ed away when using flutter_plugin_android_lifecycle #3746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tter_plugin_android_lifecycle
blasten
reviewed
Mar 30, 2021
| @@ -1,3 +1,6 @@ | |||
| ## 2.0.1 | |||
| * Make sure androidx.lifecycle.DefaultLifecycleObservable doesn't get shrunk | |||
| away. | |||
blasten
reviewed
Mar 30, 2021
| # The point of this package is to specify that a dependent plugin intends to | ||
| # use the AndroidX lifecycle classes. Make sure no R8 heuristics shrink classes | ||
| # brought in by the embedding's pom. | ||
| -keep class androidx.lifecycle.DefaultLifecycleObserver |
There was a problem hiding this comment.
Interesting. This is definitely a better fix than #3766. I'm surprised that by slightly changing the code, this rule isn't needed
11 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 30, 2021
…sing flutter_plugin_android_lifecycle (flutter/plugins#3746)
fluttergithubbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 30, 2021
…sing flutter_plugin_android_lifecycle (flutter/plugins#3746) (#79345)
fotiDim
pushed a commit
to fotiDim/plugins
that referenced
this pull request
Sep 13, 2021
…tter_plugin_android_lifecycle (flutter#3746)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#78625
Fixes flutter/flutter#69820
Fixes flutter/flutter#58479
Fixes flutter/flutter#77622