Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Make sure androidx.lifecycle classes aren't R8'ed away when using flutter_plugin_android_lifecycle #3746

Merged
xster merged 2 commits into from
Mar 30, 2021
Merged

Make sure androidx.lifecycle classes aren't R8'ed away when using flutter_plugin_android_lifecycle #3746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eae52f2
Make sure androidx.lifecycle classes aren't R8'ed away when using flu…
xster Mar 24, 2021
067d0a1
add another comment so it doesn't get refactored away
xster Mar 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/flutter_plugin_android_lifecycle/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 2.0.1
* Make sure androidx.lifecycle.DefaultLifecycleObservable doesn't get shrunk
away.
Copy link

@blasten blasten Mar 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: empty line


## 2.0.0

* Bump Dart SDK for null-safety compatibility.
Expand Down
1 change: 1 addition & 0 deletions packages/flutter_plugin_android_lifecycle/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ android {
defaultConfig {
minSdkVersion 16
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
consumerProguardFiles 'proguard.txt'
}
lintOptions {
disable 'InvalidPackage'
Expand Down
9 changes: 9 additions & 0 deletions packages/flutter_plugin_android_lifecycle/android/proguard.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# The point of this package is to specify that a dependent plugin intends to
# use the AndroidX lifecycle classes. Make sure no R8 heuristics shrink classes
# brought in by the embedding's pom.
#
# This isn't strictly needed since by definition, plugins using Android
# lifecycles should implement DefaultLifecycleObserver and therefore keep it
# from being shrunk. But there seems to be an R8 bug so this needs to stay
# https://issuetracker.google.com/issues/142778206.
-keep class androidx.lifecycle.DefaultLifecycleObserver
Copy link

@blasten blasten Mar 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. This is definitely a better fix than #3766. I'm surprised that by slightly changing the code, this rule isn't needed

2 changes: 1 addition & 1 deletion packages/flutter_plugin_android_lifecycle/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: flutter_plugin_android_lifecycle
description: Flutter plugin for accessing an Android Lifecycle within other plugins.
version: 2.0.0
version: 2.0.1
homepage: https://github.com/flutter/plugins/tree/master/packages/flutter_plugin_android_lifecycle

environment:
Expand Down