Adds data transfer to Add2App samples, using caching on Android #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
redbrogdon
commented
Oct 4, 2019
redbrogdon
commented
- Updates flutter_module to:
- Import Provider
- Track counter state via a ChangeNotifier model that uses a method channel as its source of truth.
- Updates Android to use a cached engine
- Updates both Android and iOS to:
- Set up their end of a method channel
- Track and display counter value between displays of the flutter view.
redbrogdon
commented
Oct 4, 2019
...p/android_fullscreen/app/src/main/java/dev/flutter/example/androidfullscreen/MainActivity.kt
Outdated
Show resolved
Hide resolved
...p/android_fullscreen/app/src/main/java/dev/flutter/example/androidfullscreen/MainActivity.kt
Outdated
Show resolved
Hide resolved
...p/android_fullscreen/app/src/main/java/dev/flutter/example/androidfullscreen/MainActivity.kt
Outdated
Show resolved
Hide resolved
jmagman
reviewed
Oct 4, 2019
Member
jmagman
left a comment
jmagman
left a comment
There was a problem hiding this comment.
You may want to ask someone who knows more about Swift to review that part.
experimental/add_to_app/ios_fullscreen/IOSFullScreen/ViewController.swift
Show resolved
Hide resolved
Contributor
Author
|
@matthew-carroll PTAL |
Contributor
Author
|
Updated based on offline discussion with @matthew-carroll. Mgmt of the counter's state is much simplified. |
Contributor
Author
|
@matthew-carroll, PTAL. |
matthew-carroll
approved these changes
Oct 11, 2019
matthew-carroll
left a comment
matthew-carroll
left a comment
There was a problem hiding this comment.
LGTM. Thanks for updating after our chat earlier this week!
| override fun onCreate() { | ||
| super.onCreate() | ||
|
|
||
| FlutterMain.startInitialization(this) |
There was a problem hiding this comment.
FYI, these 2 calls will no longer be required once I merge flutter/engine#12806
Contributor
Author
There was a problem hiding this comment.
Thanks for the reminder. Just CCed myself on your PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.