-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Adds data transfer to Add2App samples, using caching on Android #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
04b4e16
Working on android
redbrogdon b928d00
iOS Working.
redbrogdon ff230fe
Working Android
redbrogdon 43b6de0
Whitespace in iOS code
redbrogdon 4380b77
Protected self in iOS block
redbrogdon 95c4c52
Halfway through Android refactor
redbrogdon 3c72e18
Refactored Android
redbrogdon 53cf3df
Observable
redbrogdon 4fcf865
Licenses
redbrogdon 6ea6896
Notes toward revision
redbrogdon 4adb103
Updated state management approach.
redbrogdon dca97b0
newline
redbrogdon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55 changes: 55 additions & 0 deletions
55
...droid_fullscreen/app/src/main/java/dev/flutter/example/androidfullscreen/MyApplication.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| // Copyright 2019 The Flutter team. All rights reserved. | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| package dev.flutter.example.androidfullscreen | ||
|
|
||
| import android.app.Application | ||
| import io.flutter.embedding.engine.FlutterEngine | ||
| import io.flutter.embedding.engine.FlutterEngineCache | ||
| import io.flutter.embedding.engine.dart.DartExecutor | ||
| import io.flutter.plugin.common.MethodChannel | ||
| import io.flutter.view.FlutterMain | ||
|
|
||
| const val ENGINE_ID = "1" | ||
|
|
||
| class MyApplication : Application() { | ||
| var count = 0 | ||
|
|
||
| private var channel: MethodChannel? = null | ||
|
|
||
| override fun onCreate() { | ||
| super.onCreate() | ||
|
|
||
| FlutterMain.startInitialization(this) | ||
| FlutterMain.ensureInitializationComplete(this, null) | ||
|
|
||
| val flutterEngine = FlutterEngine(this) | ||
| flutterEngine | ||
| .dartExecutor | ||
| .executeDartEntrypoint( | ||
| DartExecutor.DartEntrypoint.createDefault() | ||
| ) | ||
|
|
||
| FlutterEngineCache.getInstance().put(ENGINE_ID, flutterEngine) | ||
|
|
||
| channel = MethodChannel(flutterEngine.dartExecutor, "dev.flutter.example/counter") | ||
|
|
||
| channel?.setMethodCallHandler { call, _ -> | ||
| when (call.method) { | ||
| "incrementCounter" -> { | ||
| count++ | ||
| reportCounter() | ||
| } | ||
| "requestCounter" -> { | ||
| print("requestCounter") | ||
| reportCounter() | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private fun reportCounter() { | ||
| channel?.invokeMethod("reportCounter", count) | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,6 +9,7 @@ environment: | |
| dependencies: | ||
| flutter: | ||
| sdk: flutter | ||
| provider: ^3.1.0 | ||
|
|
||
| dev_dependencies: | ||
| flutter_test: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, these 2 calls will no longer be required once I merge flutter/engine#12806
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the reminder. Just CCed myself on your PR.