Use registry host to get ACR access token and add new OIDCLogin function#572
Merged
Use registry host to get ACR access token and add new OIDCLogin function#572
Conversation
… registry url. This commits removes the code that parses the region from the ecr registry and uses it to set the config. By default, LoadDefaultConfig will get the region of the instance from the metadata service which is the correct region that should be used when requesting for a token. Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
… ref argument The Login function in oci/auth no longer uses the name.Reference argument and instead gets the registry host from the image argument and passes that to the Login method of the different region. This is to allow login to consumers of this function that don't have a repository name and just a registry host. Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
It also updates the Makefile to build the testapp for linux/amd64 by default. This can be changed by setting GOARCH and GOOS variables. Signed-off-by: Somtochi Onyekwere <somtochionyekwere@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes from #560 .
GCP test run: https://github.com/fluxcd/pkg/actions/runs/5082667847/jobs/9132687014
Azure test run: https://github.com/fluxcd/pkg/actions/runs/5082658720/jobs/9132668120