Merged
Conversation
matheuscscp
force-pushed
the
auth-azure
branch
3 times, most recently
from
4790c7f to
d30ee7b
Compare
matheuscscp
force-pushed
the
auth-gcp
branch
2 times, most recently
from
a41f5ed to
c8d661e
Compare
matheuscscp
force-pushed
the
auth-azure
branch
2 times, most recently
from
8685bc4 to
4d32efc
Compare
This was referenced Apr 18, 2025
Member
|
Wanted to register that I tried the |
dipti-pai
reviewed
Apr 30, 2025
Member
dipti-pai
left a comment
dipti-pai
left a comment
There was a problem hiding this comment.
Would be nice to have some tests (where possible) for the new functionality.
dipti-pai
reviewed
Apr 30, 2025
matheuscscp
force-pushed
the
auth-azure
branch
3 times, most recently
from
cd86f6e to
849f54a
Compare
Member
Author
IMO testing only errors does not add much value. Integration tests would be valuable, but we don't have credits for Azure, only AWS and GCP |
dipti-pai
approved these changes
Apr 30, 2025
stefanprodan
reviewed
May 1, 2025
matheuscscp
force-pushed
the
auth-azure
branch
2 times, most recently
from
eb537f2 to
21e0113
Compare
stefanprodan
reviewed
May 1, 2025
matheuscscp
force-pushed
the
auth-azure
branch
2 times, most recently
from
d3aa23e to
2a25d16
Compare
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the
azurelibrary from RFC-0010.Part of: fluxcd/flux2#5022
PR Stack:
azure<---gcpawscore