Skip to content

Conversation

@yegorich
Copy link
Contributor

@yegorich yegorich commented Feb 23, 2025

Handle -Wunused-parameter warning.

@yegorich yegorich marked this pull request as draft February 23, 2025 09:44
@yegorich yegorich force-pushed the warnings branch 2 times, most recently from 6167a3f to 1be6838 Compare February 23, 2025 09:51
@yegorich
Copy link
Contributor Author

This PR requires some more work.

Could you take a look at draw_graph? Why is this parameter needed at all?

What about creating a struct with all statistics parameters so that we only need to pass it to the update_stats function?

@folkertvanheusden
Copy link
Owner

Can't remember why it is introduced. It is not used so it can go away.

Declare an unused parameter as void to tell the compiler that this variable
is unused on purpose.
The parameter val wasn't used inside draw_graph(). Hence, remove it.
@yegorich yegorich changed the title Resolve warnings Resolve -Wunused-parameter Feb 24, 2025
@yegorich yegorich marked this pull request as ready for review February 24, 2025 10:29
@yegorich
Copy link
Contributor Author

This PR is now ready. I'll handle update_stats rework in a separate PR.

@folkertvanheusden folkertvanheusden merged commit 41e2236 into folkertvanheusden:master Feb 24, 2025
12 checks passed
@yegorich yegorich deleted the warnings branch March 4, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants