Make default cheerio options not escape characters#37
Conversation
|
+1 |
|
👍 great stuff |
|
💯 This issue has caused me quite a great amount of silly explanations for our current work around. 👍 |
|
What is the status on this? This is a show-stopper for us. It looks like the Milestone is 2.1.1, but the current release of Inky is 1.3.5? |
|
Also I did some testing with this PR (actually with the fix-character-escaping branch) and it is better but it still doesn't support ERB syntax. e.g. |
…o some level of raw processing
|
This turned out to be incomplete because by making cheerio be more stringent, we then resulted in errors with stuff embedded within that was invalid xml (like ERB, or <> stuff). So to work around that, I implemented a tag that just forces some stuff to not be parsed. Going to resubmit this branch against develop. To do this I needed to slightly rework how inky interacts with cheerio (moving the parsing internal to Inky rather than external) so this will necessitate a change in the template as well. |
|
That makes sense. Thanks. For reference new PR is #57 |
Fixes the escaping issues we've been seeing.