Fixes character encoding inside of <center> + minor cleanup#50
Closed
josh18 wants to merge 2 commits intofoundation:developfrom
josh18:develop
Closed
Fixes character encoding inside of <center> + minor cleanup#50josh18 wants to merge 2 commits intofoundation:developfrom josh18:develop
josh18 wants to merge 2 commits intofoundation:developfrom
josh18:develop
Conversation
added 2 commits
May 23, 2016 11:22
Fixes the issue where characters are escaped inside of a <center> element.
Member
Member
|
@josh18 Looking to pull this in for v2.2 coming soon. Are you able to add a test case here so we can ensure it passes from here on out? https://github.com/zurb/inky/blob/master/test/inky.js |
Contributor
Author
|
Sure, I haven't really written tests before so might need some help / advice. Should I modify this test |
Member
|
Good question - @kball How would you set this test up? |
Member
Contributor
Author
|
Thanks, do you know if "Removes [data-parsed] from final output" got added? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@kball might be interested in this as I just realised you were working on something similar.