Add support for ESP32-C3, ESP32-S2, and ESP32-S3 board types #1332
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1332 +/- ##
=======================================
Coverage 58.56% 58.56%
=======================================
Files 4 4
Lines 613 613
Branches 139 139
=======================================
Hits 359 359
Misses 233 233
Partials 21 21 ☔ View full report in Codecov by Sentry. |
|
@coderabbitai review |
Actions PerformedReview triggered.
|
WalkthroughThe Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- src/wled/wled.py (1 hunks)
Additional Context Used
Ruff (1)
src/wled/wled.py (1)
677-677: Line too long (119 > 88)
GitHub Check Runs (2)
codecov/patch failure (1)
src/wled/wled.py: [warning] 677-677: src/wled/wled.py#L677
Added line #L677 was not covered by testsRuff failure (2)
src/wled/wled.py: [failure] 677-677: Ruff (E501)
src/wled/wled.py:677:89: E501 Line too long (119 > 88)
Additional comments not posted (1)
src/wled/wled.py (1)
673-675: LGTM! The addition of new ESP32 board types is correctly implemented.
|
| "Upgrade is only supported on ESP01, ESP02, ESP32, ESP8266, " | ||
| "ESP32-C3, ESP32-S2, and ESP32-S3 devices" | ||
| ) | ||
| raise WLEDUpgradeError(msg) |
There was a problem hiding this comment.
You also need logic to choose the right firmware
There was a problem hiding this comment.
No? Please ellaborate, as the board type is used to pick it up.
There was a problem hiding this comment.
The ESP32-S3 build is called WLED_0.14.4_ESP32-S3_8MB.bin for example
There was a problem hiding this comment.
Aah yup you are right...
sigh, I'm not understanding why that is different upstream (inconsistent AF).
Anyways, will adjust thanks! 👍
../Frenck
There was a problem hiding this comment.
Oh wait, in v0.15 is becomes worse:
Ok, this needs more work in figuring out where is coming from. Need to order a few boards as it seems.
There was a problem hiding this comment.
Also worth noting that the logic doesn't support the ESP32_audioreactive build or the experimental _160 builds.
There was a problem hiding this comment.
Since build 2405030 and wled/WLED@674481f, Aircoookie WLED 0.15 now has a "release" name field in the info API following wled/WLED#3497
There was a problem hiding this comment.
However the challenge is really "Given the version number and architecture/release name/etc of the currently installed firmware, then guess the name of the best build of the latest firmware"
There was a problem hiding this comment.
Also worth noting that the logic doesn't support the ESP32_audioreactive build
That has never been supported by this library.
fixes #1140
Adds support for upgrading ESP32-C3, ESP32-S2, and ESP32-S3 board types in the WLED project.
upgrademethod insrc/wled/wled.pyto include ESP32-C3, ESP32-S2, and ESP32-S3 alongside the previously supported ESP01, ESP02, ESP32, and ESP8266 devices.upgrademethod to recognize and allow upgrades for the new board types.WLEDUpgradeErrorexception to reflect the inclusion of the new supported board types.For more details, open the Copilot Workspace session.
Summary by CodeRabbit
esp32-c3,esp32-s2,esp32-s3) in the WLED module.