Skip to content

Add support for ESP32-C3, ESP32-S2, and ESP32-S3 board types #1332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
frenck merged 2 commits into from
May 20, 2024
Merged

Add support for ESP32-C3, ESP32-S2, and ESP32-S3 board types #1332

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
479cfce
Add support for ESP32-C3, ESP32-S2, and ESP32-S3 board types
frenck May 18, 2024
a2bf53f
Fix long line
frenck May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/wled/wled.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -670,8 +670,14 @@ async def upgrade(self, *, version: str | AwesomeVersion) -> None:
"esp02",
"esp32",
"esp8266",
"esp32-c3",
"esp32-s2",
"esp32-s3",
}:
msg = "Upgrade is only supported on ESP01, ESP02, ESP32 and ESP8266 devices"
msg = (
"Upgrade is only supported on ESP01, ESP02, ESP32, ESP8266, "
"ESP32-C3, ESP32-S2, and ESP32-S3 devices"
)
raise WLEDUpgradeError(msg)
Copy link
Contributor

@jamesmyatt jamesmyatt May 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need logic to choose the right firmware

Copy link
Owner Author

@frenck frenck May 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No? Please ellaborate, as the board type is used to pick it up.

Copy link
Contributor

@jamesmyatt jamesmyatt May 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ESP32-S3 build is called WLED_0.14.4_ESP32-S3_8MB.bin for example

Copy link
Owner Author

@frenck frenck May 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aah yup you are right...

sigh, I'm not understanding why that is different upstream (inconsistent AF).
Anyways, will adjust thanks! 👍

../Frenck

Copy link
Owner Author

@frenck frenck May 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait, in v0.15 is becomes worse:

CleanShot 2024-05-20 at 12 40 23@2x

Ok, this needs more work in figuring out where is coming from. Need to order a few boards as it seems.

Copy link
Contributor

@jamesmyatt jamesmyatt May 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also worth noting that the logic doesn't support the ESP32_audioreactive build or the experimental _160 builds.

Copy link
Contributor

@jamesmyatt jamesmyatt May 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since build 2405030 and wled/WLED@674481f, Aircoookie WLED 0.15 now has a "release" name field in the info API following wled/WLED#3497

Copy link
Contributor

@jamesmyatt jamesmyatt May 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However the challenge is really "Given the version number and architecture/release name/etc of the currently installed firmware, then guess the name of the best build of the latest firmware"

Copy link
Owner Author

@frenck frenck May 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also worth noting that the logic doesn't support the ESP32_audioreactive build

That has never been supported by this library.


if not self._device.info.version:
Expand Down