fix: scorecard dev-push failure and gpg-verify logic bugs#72
Merged
Sandy-at-Tazama merged 1 commit intodevfrom Apr 6, 2026
Merged
fix: scorecard dev-push failure and gpg-verify logic bugs#72Sandy-at-Tazama merged 1 commit intodevfrom
Sandy-at-Tazama merged 1 commit intodevfrom
Conversation
Port of tazama-lf/workflows#46. scorecard.yml (mirrors tazama-lf/workflows#44): - Remove 'dev' from push.branches trigger. ossf/scorecard-action@v2.4.3 enforces that it can only run on the default branch regardless of publish_results; triggering on dev fails with 'Only the default branch main is supported'. gpg-verify.yml (mirrors tazama-lf/workflows#45): - Add github-actions[bot] to actor exclusion -- automated PRs from the sync workflow use this identity and cannot have GPG-signed commits. - Fix inverted git log range: origin/${PR_BASE_REF}..origin/${PR_HEAD_REF} (was backwards: listed base-only commits, not PR commits). - Replace check-runs API call (circular self-reference) with the commit verification endpoint GET /repos/.../commits/:sha and check .commit.verification.verified (boolean). - Guard against empty commit range (exit 0 cleanly).
Sandy-at-Tazama
approved these changes
Apr 6, 2026
Justus-at-Tazama
added a commit
that referenced
this pull request
Apr 8, 2026
Applies all changes from tazama-lf/workflows PR #76 (workflow audit fixes - batch 1) to frmscoe/workflows. Changes are synced verbatim from the canonical source. - fix(njsscan): fix SARIF upload guard, category, upgrade upload-sarif v4 (#68) - fix(gpg-verify): make curl error handler reachable under bash -e (#69) - fix(dco-check, gpg-verify): replace mutable branch refs with immutable SHAs (#70) - fix(package-rule): add ref guard to prevent push from non-canonical branches (#71) - fix(gpg-verify): rename workflow to Signature Verify, update header comment (#72) - fix(package-rule): pass GH_TOKEN to docker build via BuildKit secret (#73) - fix(sbom): pass GH_TOKEN to docker build via BuildKit secret (#74) - fix(dockerfile-linter): skip hadolint and upload when no Dockerfile present (#75) - fix(dockerfile-linter, sbom): address CodeRabbit review findings Signed-off-by: Justus-at-Tazama <jortlepp@contractor.linuxfoundation.org>
Justus-at-Tazama
added a commit
that referenced
this pull request
Apr 8, 2026
Applies all changes from tazama-lf/workflows PR #76 (workflow audit fixes - batch 1) to frmscoe/workflows. Changes are synced verbatim from the canonical source. - fix(njsscan): fix SARIF upload guard, category, upgrade upload-sarif v4 (#68) - fix(gpg-verify): make curl error handler reachable under bash -e (#69) - fix(dco-check, gpg-verify): replace mutable branch refs with immutable SHAs (#70) - fix(package-rule): add ref guard to prevent push from non-canonical branches (#71) - fix(gpg-verify): rename workflow to Signature Verify, update header comment (#72) - fix(package-rule): pass GH_TOKEN to docker build via BuildKit secret (#73) - fix(sbom): pass GH_TOKEN to docker build via BuildKit secret (#74) - fix(dockerfile-linter): skip hadolint and upload when no Dockerfile present (#75) - fix(dockerfile-linter, sbom): address CodeRabbit review findings Signed-off-by: Justus-at-Tazama <jortlepp@contractor.linuxfoundation.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of tazama-lf/workflows#46. Identical fixes applied to both repos.
scorecard.yml
ossf/scorecard-action@v2.4.3enforces a hard constraint that it can only run on the repository's default branch. Triggering ondevfails immediately withOnly the default branch main is supported.Fix: Remove
devfrompush.branches. Triggers are nowpush: [main], schedule (weekly),branch_protection_rule.gpg-verify.yml
Three bugs fixed:
1. Actor exclusion incomplete —
github-actions[bot]was not excluded. Automated sync PRs always failed GPG check because the bot cannot sign commits.2. Inverted git log range
3. Wrong API endpoint — was querying
/commits/:sha/check-runsfor a check named"GPG verify"(circular self-reference, returns empty on first run). Now uses/commits/:sha→.commit.verification.verified, which is the correct server-side GPG verification result.Bonus: Empty commit range guard added (exits 0 cleanly instead of looping over nothing).