ci: sync canonical workflow fixes from tazama-lf/workflows#75
Merged
Sandy-at-Tazama merged 1 commit intodevfrom Apr 6, 2026
Merged
ci: sync canonical workflow fixes from tazama-lf/workflows#75Sandy-at-Tazama merged 1 commit intodevfrom
Sandy-at-Tazama merged 1 commit intodevfrom
Conversation
Replicate all bug fixes and improvements from tazama-lf/workflows that apply to org-neutral workflow files: gpg-verify.yml: - Pass PR_HEAD_REF, PR_BASE_REF, GH_TOKEN, GH_REPO via env: block to prevent injection from github.event.pull_request.head.ref - Use printf instead of echo to safely write to GITHUB_ENV - Fix inverted git log range (was HEAD..BASE, now BASE..HEAD) - Add exit 1 + error message on failed GPG verification scorecard.yml: - Remove dev from push.branches trigger (ossf/scorecard-action only supports the default branch regardless of publish_results) release.yml: - Upgrade actions/checkout from v2 to v4 - Replace deprecated set-output with GITHUB_OUTPUT - Use heredoc syntax for multi-line outputs (changelog_contents, milestone_description) - Add continue-on-error: true to Get Latest Release step - Fix Slack notification to use SLACK_WEBHOOK_URL env var (not secret inline) and reference step output instead of env var dco-check.yml, milestone.yml: - Minor canonical updates from central workflow source workflow-docs: update all five docs to match current workflow behaviour
Sandy-at-Tazama
approved these changes
Apr 6, 2026
Sandy-at-Tazama
approved these changes
Apr 6, 2026
Justus-at-Tazama
added a commit
that referenced
this pull request
Apr 8, 2026
Applies all changes from tazama-lf/workflows PR #76 (workflow audit fixes - batch 1) to frmscoe/workflows. Changes are synced verbatim from the canonical source. - fix(njsscan): fix SARIF upload guard, category, upgrade upload-sarif v4 (#68) - fix(gpg-verify): make curl error handler reachable under bash -e (#69) - fix(dco-check, gpg-verify): replace mutable branch refs with immutable SHAs (#70) - fix(package-rule): add ref guard to prevent push from non-canonical branches (#71) - fix(gpg-verify): rename workflow to Signature Verify, update header comment (#72) - fix(package-rule): pass GH_TOKEN to docker build via BuildKit secret (#73) - fix(sbom): pass GH_TOKEN to docker build via BuildKit secret (#74) - fix(dockerfile-linter): skip hadolint and upload when no Dockerfile present (#75) - fix(dockerfile-linter, sbom): address CodeRabbit review findings Signed-off-by: Justus-at-Tazama <jortlepp@contractor.linuxfoundation.org>
Justus-at-Tazama
added a commit
that referenced
this pull request
Apr 8, 2026
Applies all changes from tazama-lf/workflows PR #76 (workflow audit fixes - batch 1) to frmscoe/workflows. Changes are synced verbatim from the canonical source. - fix(njsscan): fix SARIF upload guard, category, upgrade upload-sarif v4 (#68) - fix(gpg-verify): make curl error handler reachable under bash -e (#69) - fix(dco-check, gpg-verify): replace mutable branch refs with immutable SHAs (#70) - fix(package-rule): add ref guard to prevent push from non-canonical branches (#71) - fix(gpg-verify): rename workflow to Signature Verify, update header comment (#72) - fix(package-rule): pass GH_TOKEN to docker build via BuildKit secret (#73) - fix(sbom): pass GH_TOKEN to docker build via BuildKit secret (#74) - fix(dockerfile-linter): skip hadolint and upload when no Dockerfile present (#75) - fix(dockerfile-linter, sbom): address CodeRabbit review findings Signed-off-by: Justus-at-Tazama <jortlepp@contractor.linuxfoundation.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replicates all org-neutral bug fixes from tazama-lf/workflows to frmscoe/workflows.
Changes
gpg-verify.yml (security + logic fixes):
env:block to prevent expression injectionprintfinstead ofechofor safe GITHUB_ENV writesexit 1+ error message on failed GPG verificationscorecard.yml:
devfrompush.branches(ossf/scorecard-action only supports the default branch)release.yml:
actions/checkoutfrom v2 to v4set-outputwithGITHUB_OUTPUTcontinue-on-error: trueto Get Latest Release stepdco-check.yml, milestone.yml: minor canonical updates
workflow-docs: updated to match current workflow behaviour
Not changed:
sync-workflows.yml,publish.yml,release-train.yml(have intentional org-specific differences)