Merged
Conversation
Collaborator
|
Test failure on windows: |
Contributor
Author
|
Hello, After investigation, the failing test is The error message you highlighted about an invalid date is output by the I'm not sure why the Do you think it would be possible to simply run the build again? |
cartermp
approved these changes
Jun 11, 2022
Collaborator
|
Yeah, the tests aren't ideal. Ah well! Thanks a bunch, it looks good. |
Contributor
Author
|
Thanks a lot! |
This was referenced Mar 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Closes #1215
Feel free to discuss!
One thing of note: there is no way to disallow comments in json now.
I didn't feel like it was something the user would usually want, but there might be some edge cases where it could be needed (especially since it's not standard json).
I'm not sure what would be the best way to support this option without littering the parsing methods with a boolean or something like that... (and how to keep backward compat)
Bonus:
.gitattributesto format new lines the same way.editorconfigwants them:lffor almost all file types. (I did this after having multiple problems while working in the code and having mixed CRLF and LF...)(These are the same changes I did in PR Implement "inline schemas": ability to add type hints into the type providers' source documents #1447. I'm thinking that it might be easier to get them accepted in this small PR, so I can remove them from the big one and make it easier to review)