Skip to content

Some medium refactoring and little fixes#1450

Merged
cartermp merged 4 commits intofsprojects:mainfrom
mlaily:medium-refacto-and-little-fixes
Jun 20, 2022
Merged

Some medium refactoring and little fixes#1450
cartermp merged 4 commits intofsprojects:mainfrom
mlaily:medium-refacto-and-little-fixes

Conversation

@mlaily
Copy link
Copy Markdown
Contributor

@mlaily mlaily commented Jun 12, 2022

This is a series of commits I did while working on #1447 and #1448 that were not strictly necessary for the aforementioned PRs to work, but I think it might be nice to have anyway.

Changes:

  • Fix an out of bound exception I saw while debugging the providers. It might not happen when the providers work, but now it will never crash and is better documented.
  • We have a PrimitiveInferedProperty to represent a type and a name, but there are several cases where we just want a type, so I added a PrimitiveInferedValue to do just that. The core or Implement "inline schemas": ability to add type hints into the type providers' source documents #1447 was initially based on this change, but in the end I did it another way.
  • As seen in Skip json comments #1448, there is a test that ensures an xsd is seen as invalid. Unfortunately, this test outputs an error message in the console that is very confusing because the test works. I suppressed this message.

If you feel like some commits are undesirable, I can remove them...
Oh, and this should merge cleanly with #1447 BTW. Unless the auto-formatting messed something after I checked.

Copy link
Copy Markdown
Collaborator

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cartermp cartermp merged commit 0d973d4 into fsprojects:main Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants