Some medium refactoring and little fixes#1450
Merged
cartermp merged 4 commits intofsprojects:mainfrom Jun 20, 2022
Merged
Conversation
… self documentation
… when we don't have a property name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a series of commits I did while working on #1447 and #1448 that were not strictly necessary for the aforementioned PRs to work, but I think it might be nice to have anyway.
Changes:
PrimitiveInferedPropertyto represent a type and a name, but there are several cases where we just want a type, so I added aPrimitiveInferedValueto do just that. The core or Implement "inline schemas": ability to add type hints into the type providers' source documents #1447 was initially based on this change, but in the end I did it another way.If you feel like some commits are undesirable, I can remove them...
Oh, and this should merge cleanly with #1447 BTW. Unless the auto-formatting messed something after I checked.