Skip to content

Update Paket to v7.2.1#603

Closed
Numpsy wants to merge 1 commit into
fsprojects:masterfrom
Numpsy:rw/paket_bump
Closed

Update Paket to v7.2.1#603
Numpsy wants to merge 1 commit into
fsprojects:masterfrom
Numpsy:rw/paket_bump

Conversation

@Numpsy
Copy link
Copy Markdown
Contributor

@Numpsy Numpsy commented Oct 30, 2023

Paket updated with dotnet tool update paket.

Reasoning:

The 5.252.0 version it currently uses doesn't understand .NET 6, so it needs to be updated to a newer version.
As the new version still works with .NET 5, it could be updated as a stand alone step to reduce the number of changes needed later.

@knocte
Copy link
Copy Markdown
Collaborator

knocte commented Oct 30, 2023

Hello Richard, thanks for your PR!

Does this fix anything in particular? Or, if not, does it pave the way for further fixes?

@Numpsy
Copy link
Copy Markdown
Contributor Author

Numpsy commented Oct 30, 2023

It was initially because I'd tried to update some deps like the compiler service to see what would happen with the build and got some warnings like

Download of System.Diagnostics.DiagnosticSource 7.0.2 done in 360 milliseconds. (8860 kbit/s, 0 MB)
Could not detect any platforms from 'net6.0' in 'C:\Users\Richard Webb\.nuget\packages\system.diagnostics.diagnosticsource\7.0.2\system.diagnostics.diagnosticsource.nuspec', please tell the package authors
Could not detect any platforms from 'net7.0' in 'C:\Users\Richard Webb\.nuget\packages\system.diagnostics.diagnosticsource\7.0.2\system.diagnostics.diagnosticsource.nuspec', please tell the package authors
Could not detect any platforms from 'net6.0' in 'C:\Users\Richard Webb\.nuget\packages\system.diagnostics.diagnosticsource\7.0.2\lib\net6.0\System.Diagnostics.DiagnosticSource.dll', please tell the package authors
Could not detect any platforms from 'net7.0' in 'C:\Users\Richard Webb\.nuget\packages\system.diagnostics.diagnosticsource\7.0.2\lib\net7.0\System.Diagnostics.DiagnosticSource.dll', please tell the package authors
Could not detect any platforms from 'net6.0' in 'C:\Users\Richard Webb\.nuget\packages\system.reflection.metadata\7.0.2\system.reflection.metadata.nuspec', please tell the package authors
Could not detect any platforms from 'net7.0' in 'C:\Users\Richard Webb\.nuget\packages\system.reflection.metadata\7.0.2\system.reflection.metadata.nuspec', please tell the package authors
Could not detect any platforms from 'net6.0' in 'C:\Users\Richard Webb\.nuget\packages\system.reflection.metadata\7.0.2\lib\net6.0\System.Reflection.Metadata.dll', please tell the package authors
Could not detect any platforms from 'net7.0' in 'C:\Users\Richard Webb\.nuget\packages\system.reflection.metadata\7.0.2\lib\net7.0\System.Reflection.Metadata.dll', please tell the package authors
Could not detect any platforms from 'net6.0' in 'C:\Users\Richard Webb\.nuget\packages\system.runtime.compilerservices.unsafe\6.0.0\system.runtime.compilerservices.unsafe.nuspec', please tell the package authors
Could not detect any platforms from 'net6.0' in 'C:\Users\Richard Webb\.nuget\packages\system.runtime.compilerservices.unsafe\6.0.0\lib\net6.0\System.Runtime.CompilerServices.Unsafe.dll', please tell the package authors

which I thought might be related to Paket not understanding those versions (they went away after the update in anycase, but my knowldge of Paket is rather small so maybe theres some other issue).

More generally though, the build is done with .NET 5 and I suppose it could do with updating to something more supported, for which updated tools should help

@Numpsy
Copy link
Copy Markdown
Contributor Author

Numpsy commented Oct 30, 2023

Actually on a related note - the global.json refers to version 5.0.202 of the SDK and I don't have that available on this system - I have to add a

"rollForward": "latestMinor"

to build it, so maybe that's something to look at as well

@knocte
Copy link
Copy Markdown
Collaborator

knocte commented Oct 31, 2023

It was initially because I'd tried to update some deps like the compiler service

And this update's purpose was...?

More generally though, the build is done with .NET 5 and I suppose it could do with updating to something more supported,

Ah yeah, I would merge a PR that updates to .NET6 given that v6 is LTS.

I have to add a "rollForward": "latestMinor" to build it, so maybe that's something to look at as well

Yeah let's propose this in a different PR.

@Numpsy
Copy link
Copy Markdown
Contributor Author

Numpsy commented Oct 31, 2023

And this update's purpose was...?

I'd enquired about the status of FSAutoComplete / Ionide integration in ionide/FsAutoComplete#942 and there are comments about it being broken due to the compiler libraries being out of step, so I thought i'd try to see how much difference there actually is (it doesn't build with the latest FCS, as seems to be expected)

This was referenced Oct 31, 2023
  Updated with 'dotnet tool update paket'
@Numpsy Numpsy closed this Dec 19, 2023
@Numpsy Numpsy deleted the rw/paket_bump branch December 19, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants