Build with the .NET 6 SDK#605
Conversation
| <PropertyGroup> | ||
| <TreatWarningsAsErrors>true</TreatWarningsAsErrors> | ||
| <MSBuildTreatWarningsAsErrors>true</MSBuildTreatWarningsAsErrors> | ||
| <MSBuildTreatWarningsAsErrors>false</MSBuildTreatWarningsAsErrors> |
There was a problem hiding this comment.
disabled this for now, as there are warnings about .NET 5 being unsupported
There was a problem hiding this comment.
but isn't this PR upgrading from v5 to v6? then this warning should be gone in this PR
| | _ -> checkExpr app None) | ||
| | _ -> Array.empty | ||
| | _ -> Array.empty | ||
| // | _ -> Array.empty |
There was a problem hiding this comment.
The newer sdks have this warning here
FSharpLint\src\FSharpLint.Core\Rules\Conventions\RaiseWithTooManyArguments\FailwithBadUsage.fs(119,11): error FS0026: This rule will never be matched
(which cause a build failure due to WarningsAsErrors being enabled)
| let f() = | ||
| let g() = | ||
| {(makeMatchSnippet (MaxComplexity+1)) |> indent 8} | ||
| {(makeMatchSnippet (MaxComplexity+1)) |> indent 8} |
There was a problem hiding this comment.
The newer SDKs have this warning here
FSharpLint\tests\FSharpLint.Core.Tests\Rules\Conventions\CyclomaticComplexity.fs(232,3): error FS0058: Possible incorrect indentation: this token is offside of context started at position (229:9). Try indenting this token further or using standard formatting conventions.
| - name: Setup .NET 6 | ||
| uses: actions/setup-dotnet@v1 | ||
| with: | ||
| dotnet-version: '6.x' |
There was a problem hiding this comment.
@Numpsy why not upgrade from v5 to v6 everywhere? (specifically, am wondering why you left 5.0.x in L15)
|
It was an attempt to do one thing at once, and show those two code changes which could be done separately if wanted. Also it needs Paket to be updated as in #603 as the existing version doesn't understand the newer TFMs |
|
I'll close this in favour of #606 |
2 participants
refs #604
A basic start to update to something supported, and to handle a couple of compiler warnings that occur with newer SDK versions