Try to get the docs building with NuGet instead of Paket #733
Conversation
| ] | ||
| for (label, dll) in dlls do | ||
| let output = MetadataFormat.Generate(dll, markDownComments = true, publicOnly = true, libDirs = libs) | ||
| let output = MetadataFormat.Generate(dllFile = dll, markDownComments = true, publicOnly = true, libDirs = libs, parameters = [("project-name", label)]) |
There was a problem hiding this comment.
This is a go at fixing the 'no project name specified' error at https://github.com/Numpsy/FSharpLint/actions/runs/16079166194/job/45380884425#step:7:58
|
The CI needs #732 before it gets far enough to test this - this works locally for me on Windows at least |
|
Will conflict with #723 |
Numpsy
changed the title
|
The 'deployReleaseBinaries' CI step seems to be running the unit tests 3 times - is that needed? The CI has worked now at least though :-) |
|
I don't see it running 3 times in YAML definition. Could you show me where you have seen that? |
…#698) Remove workaround introduced in [1] for bug in FCS [2] that was fixed in FCS 43.8.200. [1] webwarrior-ws@106be3f [2] dotnet/fsharp#16121
|
The build logs for the 'deplyReleseBinaries' step in https://github.com/fsprojects/FSharpLint/actions/runs/16099807422/job/45427611835 the logs make it look like the 'Build', 'Pack' and 'Upload binaries to 'NuGet' steps are each running the unit tests |
|
Not sure what happened with the CI - the previous build at https://github.com/fsprojects/FSharpLint/actions/runs/16097394981/job/45422360643 worked |
|
It's currently using an old version of Fornax that was built against .NET Core 3.1 - maybe it doesn't support the string interpolation changes? |
|
Pretty much possible |
|
Won't it build with a higher version of SDK? Or 3.1+9? |
I was thinking that there could be issues due to the versions of Fornax and FSharp.Formatting that it uses having a quite old version of FSharp.Compiler.Service built in to it, which can't handle the newer language syntax (just an assumption though). The other PR to use the newer Fornax seems a better idea ging forwards though (don't really want to be depending on .NET Core 3.1 tool at this point) |
Ah nevermind, I had only glimpsed only at the title and missed the word "docs". Ok, so this is also about Fornax. |
|
superceeded by #736 |
4 participants
An attempt at getting the Fornax docs build to work without Paket (it expects various dlls to be in certain places, where they used to be put by Paket)
Borrows the approach from #680 of using PackageDownload to get the packages, but isn't quite working in the CI yet with a failure i'm not clear on (I haven't used Fornax before)