Some janitorial changes #824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After we have landed support for serializing simple DUs in [1] (part of [2]), there's no need to have dummy values in the members of these types (in order to force them to be enums). [1] 06ca9c2 [2] fsprojects#794
Introduced in [1] (part of [2]). [1] 8c82599 [2] fsprojects#774
knocte
force-pushed
the
wip/janitorialTasks
branch
from
9b08934 to
494ede4
Compare
knocte
force-pushed
the
wip/janitorialTasks
branch
from
4eab8bc to
9102234
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.