Skip to content

Add Custom Field Configuration Editor for Shoot Clusters#1926

Merged
petersutter merged 15 commits into
masterfrom
enh/custom-fields-editor
Jun 27, 2024
Merged

Add Custom Field Configuration Editor for Shoot Clusters#1926
petersutter merged 15 commits into
masterfrom
enh/custom-fields-editor

Conversation

@petersutter
Copy link
Copy Markdown
Member

@petersutter petersutter commented Jun 19, 2024 •
edited
Loading

What this PR does / why we need it:
This PR introduces an editor for custom shoot fields. The new feature allows users to configure custom fields directly from the dashboard without needing to use kubectl.
custom-fields-5
custom-fields-6
custom-fields-7

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

You can now configure custom shoot fields directly from the dashboard using the new editor, eliminating the need to use `kubectl`.

@ghost ghost added the needs/review Needs review label Jun 19, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 19, 2024
@ghost ghost added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs/second-opinion Needs second review by someone else labels Jun 19, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 19, 2024
@petersutter petersutter force-pushed the enh/custom-fields-editor branch from 6ce7e6f to 8b144c6 Compare June 19, 2024 15:03
@ghost ghost added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 19, 2024
@petersutter petersutter force-pushed the enh/custom-fields-editor branch from 8b144c6 to 6ff9e2b Compare June 20, 2024 10:26
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 20, 2024
@petersutter petersutter force-pushed the enh/custom-fields-editor branch from 6ff9e2b to da798c7 Compare June 20, 2024 13:47
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 20, 2024
@petersutter petersutter force-pushed the enh/custom-fields-editor branch from da798c7 to bdae105 Compare June 20, 2024 15:47
@ghost ghost added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 20, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 20, 2024
@petersutter petersutter force-pushed the enh/custom-fields-editor branch from bdae105 to 2e03019 Compare June 21, 2024 08:27
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 21, 2024
@ghost ghost removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 21, 2024
@petersutter petersutter force-pushed the enh/custom-fields-editor branch from 2e03019 to f9e12d9 Compare June 21, 2024 09:07
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 21, 2024
@petersutter
Copy link
Copy Markdown
Member Author

petersutter commented Jun 21, 2024 •
edited
Loading

  • cancel / save buttons always visible on dialog
  • update project on edit dialog close / delete field
  • icon in primary colour
  • path input full width
  • not defined / unknown / - we leave it as is for now
  • support different types (plain, link) - we wait for feedback

@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 21, 2024
@ghost ghost removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 21, 2024
@petersutter petersutter force-pushed the enh/custom-fields-editor branch from c4b235c to 6bf35c1 Compare June 21, 2024 14:55
@ghost ghost removed the reviewed/lgtm Has approval for merging label Jun 26, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 26, 2024
grolu
grolu reviewed Jun 26, 2024
View reviewed changes
Comment thread frontend/src/components/GShootListRow.vue Outdated
grolu
grolu reviewed Jun 26, 2024
View reviewed changes
Comment thread frontend/src/components/GShootListRow.vue Outdated
grolu
grolu reviewed Jun 26, 2024
View reviewed changes
Comment thread frontend/src/components/GShootListRow.vue
grolu
grolu reviewed Jun 26, 2024
View reviewed changes
Comment thread frontend/src/components/ShootDetails/GCustomFieldsCard.vue Outdated
grolu
grolu reviewed Jun 26, 2024
View reviewed changes
Comment thread frontend/src/components/ShootDetails/GCustomFieldsCard.vue Outdated
grolu
grolu reviewed Jun 26, 2024
View reviewed changes
Comment thread frontend/src/components/ShootDetails/GCustomFieldsCard.vue Outdated
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 26, 2024
@ghost ghost removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 26, 2024
@petersutter @grolu
Apply suggestions from code review
9918e26 
Co-authored-by: Lukas Gross <lukas.gross@sap.com>
@petersutter petersutter force-pushed the enh/custom-fields-editor branch from 960c1be to 9918e26 Compare June 26, 2024 17:19
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 26, 2024
@grolu
Copy link
Copy Markdown
Member

grolu commented Jun 27, 2024

/lgtm

@ghost ghost added reviewed/lgtm Has approval for merging and removed needs/second-opinion Needs second review by someone else labels Jun 27, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 27, 2024
@ghost ghost added needs/second-opinion Needs second review by someone else and removed reviewed/lgtm Has approval for merging labels Jun 27, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 27, 2024
@petersutter petersutter merged commit cc8d1f4 into master Jun 27, 2024
@petersutter petersutter deleted the enh/custom-fields-editor branch June 27, 2024 11:00
@ghost ghost added the status/closed Issue is closed (either delivered or triaged) label Jun 27, 2024
@petersutter petersutter mentioned this pull request Jun 27, 2024
Merged
holgerkoser added a commit that referenced this pull request Jul 4, 2024
@holgerkoser
Merge branch 'master' into enh/mfp-hackaton
c4f9304 
* master:
  Update dependency vite to v5.3.3 (#1954)
  Update dependency eslint-plugin-vue to v9.27.0 (#1948)
  Update dependency eslint-plugin-promise to v6.4.0 (#1945)
  Update dependency jose to v5.6.2 (#1941)
  Update dependency vite to v5.3.2 (#1942)
  including the iss parameter in server code exchange (#1939)
  Update dependency vue to v3.4.31 (#1944)
  Fix issue when no costObject is defined (#1943)
  Update dependency path-to-regexp to v7 (#1930)
  Update Yarn to v4.3.1 (#1931)
  Update dependency prom-client to v15.1.3 (#1940)
  Update dependency vue to v3.4.30 (#1935)
  Update dependency jose to v5.5.0 (#1938)
  Update dependency vue-router to v4.4.0 (#1932)
  Add Custom Field Configuration Editor for Shoot Clusters (#1926)

# Conflicts:
#	.pnp.cjs
#	.yarn/cache/@vue-compiler-core-npm-3.4.29-29bc9e7853-9d68fd1a0c.zip
#	.yarn/cache/@vue-compiler-core-npm-3.4.30-f4933d9063-f0109b472d.zip
#	.yarn/cache/@vue-compiler-core-npm-3.4.31-f79d05324a-17833fa55a.zip
#	.yarn/cache/@vue-compiler-dom-npm-3.4.29-a117217369-c98620b718.zip
#	.yarn/cache/@vue-compiler-dom-npm-3.4.30-7742f540f5-b975fcb1a6.zip
#	.yarn/cache/@vue-compiler-dom-npm-3.4.31-6d2d250445-136b220868.zip
#	.yarn/cache/@vue-compiler-sfc-npm-3.4.29-25de7bdaef-4db562793d.zip
#	.yarn/cache/@vue-compiler-sfc-npm-3.4.30-7854a51719-63b09e7d9d.zip
#	.yarn/cache/@vue-compiler-sfc-npm-3.4.31-25353c4cc2-b8983a52dd.zip
#	.yarn/cache/@vue-compiler-ssr-npm-3.4.29-acc329a1f4-a12cc3ecc0.zip
#	.yarn/cache/@vue-compiler-ssr-npm-3.4.30-bf06ebff88-f7ba4bde96.zip
#	.yarn/cache/@vue-compiler-ssr-npm-3.4.31-9533893acb-8083959c21.zip
#	.yarn/cache/@vue-reactivity-npm-3.4.29-60fd993ecd-cc465ba167.zip
#	.yarn/cache/@vue-reactivity-npm-3.4.30-241edc7af3-b6ca8281f4.zip
#	.yarn/cache/@vue-reactivity-npm-3.4.31-6fb2cecc5c-974ce9c9f2.zip
#	.yarn/cache/@vue-runtime-core-npm-3.4.29-2bd370acac-1580ac9dae.zip
#	.yarn/cache/@vue-runtime-core-npm-3.4.30-a2886d20a5-f496a9bd99.zip
#	.yarn/cache/@vue-runtime-core-npm-3.4.31-fb7fdb78b9-446711364e.zip
#	.yarn/cache/@vue-runtime-dom-npm-3.4.29-dff1aa2f2a-b307e9a166.zip
#	.yarn/cache/@vue-runtime-dom-npm-3.4.30-6ed8273a18-69fa19e5a7.zip
#	.yarn/cache/@vue-runtime-dom-npm-3.4.31-18c8027dfb-4c0b20f16a.zip
#	.yarn/cache/@vue-server-renderer-npm-3.4.29-b7dad78c9d-c414447049.zip
#	.yarn/cache/@vue-server-renderer-npm-3.4.30-98a18cf281-6313e7f71c.zip
#	.yarn/cache/@vue-server-renderer-npm-3.4.31-a7fc49ff3c-1e01142c2f.zip
#	.yarn/cache/@vue-shared-npm-3.4.29-f059414627-7569bb841f.zip
#	.yarn/cache/@vue-shared-npm-3.4.30-8d6e063bf4-39e128f9b2.zip
#	.yarn/cache/@vue-shared-npm-3.4.31-07b999feaf-45643c0c7a.zip
#	.yarn/cache/jose-npm-5.4.1-82d453ef52-51234a7383.zip
#	.yarn/cache/jose-npm-5.5.0-f42a134c93-e240caa9f7.zip
#	.yarn/cache/jose-npm-5.6.2-6dd6e106fc-86df192545.zip
#	.yarn/cache/vue-npm-3.4.29-5618bba5e0-1a84802f74.zip
#	.yarn/cache/vue-npm-3.4.30-52ebe7d44e-0d0f5d8841.zip
#	.yarn/cache/vue-npm-3.4.31-375a256262-d9d7ac45f2.zip
#	backend/lib/security/index.js
#	frontend/src/views/GAdministration.vue
#	yarn.lock
@grolu grolu added the area/ipcei IPCEI (Important Project of Common European Interest) label Jul 17, 2024
@grolu grolu mentioned this pull request Jul 17, 2024
Open
@grolu grolu mentioned this pull request Sep 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grolu grolu grolu left review comments

@holgerkoser holgerkoser holgerkoser approved these changes

Assignees

No one assigned

Labels

area/ipcei IPCEI (Important Project of Common European Interest) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/second-opinion Needs second review by someone else size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/closed Issue is closed (either delivered or triaged)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@petersutter @grolu @holgerkoser @gardener-robot-ci-1 @gardener-robot-ci-2