including the iss parameter in server code exchange#1939
Merged
Conversation
|
|
|
@lekev Thank you for your contribution. |
ghost
added
needs/review
|
Thank you @lekev for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below. |
Member
|
Thank you for submitting this pull request. We encountered the same issue today and addressed it in a recent commit. Could you please update your pull request to align with the approach we took in this commit: d752df1 |
holgerkoser
added
the
reviewed/ok-to-test
gardener-robot-ci-2
added
needs/ok-to-test
ghost
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
Member
|
The build fails because there are two |
gardener-robot-ci-1
added
the
reviewed/ok-to-test
ghost
added
reviewed/lgtm
ghost
added
the
reviewed/ok-to-test
gardener-robot-ci-1
removed
the
reviewed/ok-to-test
holgerkoser
added a commit
that referenced
this pull request
Jul 4, 2024
* master: Update dependency vite to v5.3.3 (#1954) Update dependency eslint-plugin-vue to v9.27.0 (#1948) Update dependency eslint-plugin-promise to v6.4.0 (#1945) Update dependency jose to v5.6.2 (#1941) Update dependency vite to v5.3.2 (#1942) including the iss parameter in server code exchange (#1939) Update dependency vue to v3.4.31 (#1944) Fix issue when no costObject is defined (#1943) Update dependency path-to-regexp to v7 (#1930) Update Yarn to v4.3.1 (#1931) Update dependency prom-client to v15.1.3 (#1940) Update dependency vue to v3.4.30 (#1935) Update dependency jose to v5.5.0 (#1938) Update dependency vue-router to v4.4.0 (#1932) Add Custom Field Configuration Editor for Shoot Clusters (#1926) # Conflicts: # .pnp.cjs # .yarn/cache/@vue-compiler-core-npm-3.4.29-29bc9e7853-9d68fd1a0c.zip # .yarn/cache/@vue-compiler-core-npm-3.4.30-f4933d9063-f0109b472d.zip # .yarn/cache/@vue-compiler-core-npm-3.4.31-f79d05324a-17833fa55a.zip # .yarn/cache/@vue-compiler-dom-npm-3.4.29-a117217369-c98620b718.zip # .yarn/cache/@vue-compiler-dom-npm-3.4.30-7742f540f5-b975fcb1a6.zip # .yarn/cache/@vue-compiler-dom-npm-3.4.31-6d2d250445-136b220868.zip # .yarn/cache/@vue-compiler-sfc-npm-3.4.29-25de7bdaef-4db562793d.zip # .yarn/cache/@vue-compiler-sfc-npm-3.4.30-7854a51719-63b09e7d9d.zip # .yarn/cache/@vue-compiler-sfc-npm-3.4.31-25353c4cc2-b8983a52dd.zip # .yarn/cache/@vue-compiler-ssr-npm-3.4.29-acc329a1f4-a12cc3ecc0.zip # .yarn/cache/@vue-compiler-ssr-npm-3.4.30-bf06ebff88-f7ba4bde96.zip # .yarn/cache/@vue-compiler-ssr-npm-3.4.31-9533893acb-8083959c21.zip # .yarn/cache/@vue-reactivity-npm-3.4.29-60fd993ecd-cc465ba167.zip # .yarn/cache/@vue-reactivity-npm-3.4.30-241edc7af3-b6ca8281f4.zip # .yarn/cache/@vue-reactivity-npm-3.4.31-6fb2cecc5c-974ce9c9f2.zip # .yarn/cache/@vue-runtime-core-npm-3.4.29-2bd370acac-1580ac9dae.zip # .yarn/cache/@vue-runtime-core-npm-3.4.30-a2886d20a5-f496a9bd99.zip # .yarn/cache/@vue-runtime-core-npm-3.4.31-fb7fdb78b9-446711364e.zip # .yarn/cache/@vue-runtime-dom-npm-3.4.29-dff1aa2f2a-b307e9a166.zip # .yarn/cache/@vue-runtime-dom-npm-3.4.30-6ed8273a18-69fa19e5a7.zip # .yarn/cache/@vue-runtime-dom-npm-3.4.31-18c8027dfb-4c0b20f16a.zip # .yarn/cache/@vue-server-renderer-npm-3.4.29-b7dad78c9d-c414447049.zip # .yarn/cache/@vue-server-renderer-npm-3.4.30-98a18cf281-6313e7f71c.zip # .yarn/cache/@vue-server-renderer-npm-3.4.31-a7fc49ff3c-1e01142c2f.zip # .yarn/cache/@vue-shared-npm-3.4.29-f059414627-7569bb841f.zip # .yarn/cache/@vue-shared-npm-3.4.30-8d6e063bf4-39e128f9b2.zip # .yarn/cache/@vue-shared-npm-3.4.31-07b999feaf-45643c0c7a.zip # .yarn/cache/jose-npm-5.4.1-82d453ef52-51234a7383.zip # .yarn/cache/jose-npm-5.5.0-f42a134c93-e240caa9f7.zip # .yarn/cache/jose-npm-5.6.2-6dd6e106fc-86df192545.zip # .yarn/cache/vue-npm-3.4.29-5618bba5e0-1a84802f74.zip # .yarn/cache/vue-npm-3.4.30-52ebe7d44e-0d0f5d8841.zip # .yarn/cache/vue-npm-3.4.31-375a256262-d9d7ac45f2.zip # backend/lib/security/index.js # frontend/src/views/GAdministration.vue # yarn.lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This Pull Request adds compatibility for the Authorization Server Issuer Identification extension as specified in RFC 9207. This extension requires the inclusion of the iss parameter, received from the Authorization Response, in the token request.
Which issue(s) this PR fixes:
Implementing this change resolves the "iss missing from the response" error that authorization servers using this extension may encounter.
Special notes for your reviewer:
Release note: