Skip to content

Fix issues with hibernation schedule dialog#2076

Merged
petersutter merged 2 commits into
masterfrom
bug/hibernation-schedule
Sep 17, 2024
Merged

Fix issues with hibernation schedule dialog#2076
petersutter merged 2 commits into
masterfrom
bug/hibernation-schedule

Conversation

@petersutter
Copy link
Copy Markdown
Member

@petersutter petersutter commented Sep 12, 2024

What this PR does / why we need it:
This PR fixes two issues with the hibernation schedule dialog, where

Which issue(s) this PR fixes:
Fixes #2061

Special notes for your reviewer:

Release note:

Fixed issues with hibernation schedule dialog: reset button and time saving

@ghost ghost added needs/review Needs review size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 12, 2024
grolu
grolu approved these changes Sep 17, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@grolu grolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ghost ghost added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Sep 17, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 17, 2024
@ghost ghost removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 17, 2024
holgerkoser
holgerkoser approved these changes Sep 17, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@petersutter petersutter merged commit fb46f36 into master Sep 17, 2024
@petersutter petersutter deleted the bug/hibernation-schedule branch September 17, 2024 14:49
@ghost ghost added the status/closed Issue is closed (either delivered or triaged) label Sep 17, 2024
holgerkoser added a commit that referenced this pull request Sep 20, 2024
@holgerkoser
Merge branch 'master' into enh/eslint-plugin-security
a337100 
# By Gardener Prow Robot (50) and others
# Via GitHub
* master: (62 commits)
  Update dependency codemirror to v5.65.18 (#2101)
  Update dependency vite to v5.4.6 [SECURITY] (#2096)
  Fix issues with hibernation schedule dialog (#2076)
  Hide SSH keypair rotation when SSH access disabled (#2077)
  remove unnecessary model-value binding (#2080)
  Fix vite warning (#2090)
  Update dependency vuetify to v3.7.2 (#2095)
  Update vueuse monorepo to v11.1.0 (#2094)
  Update dependency @vueuse/core to v11.1.0 (#2091)
  Update dependency chokidar to v4 (#2081)
  Update dependency @fontsource/roboto to v5.1.0 (#2078)
  Update dependency jose to v5.9.2 (#2087)
  Update dependency express to v4.20.0 [SECURITY] (#2084)
  Update dependency vue to v3.5.6 (#2089)
  Update Yarn to v4.5.0 (#2088)
  Update dependency vue to v3.5.5 (#2086)
  Update dependency vue-router to v4.4.5 (#2083)
  Update dependency express-static-gzip to v2.1.8 (#2082)
  Update dependency vue-router to v4.4.4 (#2075)
  Update dependency openid-client to v5.7.0 (#2069)
  ...

# Conflicts:
#	.pnp.cjs
#	backend/package.json
#	frontend/package.json
#	frontend/src/components/ShootAddons/GManageAddons.vue
#	packages/kube-client/package.json
#	packages/kube-config/package.json
#	packages/logger/package.json
#	packages/monitor/package.json
#	packages/request/package.json
#	yarn.lock
@grolu grolu added the area/ipcei IPCEI (Important Project of Common European Interest) label Oct 14, 2024
@grolu grolu mentioned this pull request Oct 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@holgerkoser holgerkoser holgerkoser approved these changes

@grolu grolu grolu approved these changes

Assignees

No one assigned

Labels

area/ipcei IPCEI (Important Project of Common European Interest) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/closed Issue is closed (either delivered or triaged)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Hibernation Schedule "Wake up at" Time Not Saved in the Dialog

4 participants

@petersutter @holgerkoser @grolu @gardener-robot-ci-2