Skip to content

Fix vite warning#2090

Merged
petersutter merged 2 commits into
masterfrom
fix-vite-warning
Sep 17, 2024
Merged

Fix vite warning#2090
petersutter merged 2 commits into
masterfrom
fix-vite-warning

Conversation

@petersutter
Copy link
Copy Markdown
Member

@petersutter petersutter commented Sep 16, 2024

What this PR does / why we need it:
This PR fixes the following vite warning and also improves a help text

10:11:55 AM [vite] warning: <pre> cannot be child of <p>, according to HTML specifications. This can cause hydration errors or potentially disrupt future functionality.
40 |          </p>
41 |          <p>
42 |            <pre>$ echo -n '1234567890123456789' | base64</pre>
   |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
43 |          </p>
44 |          <p>
  Plugin: vite:vue

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

@ghost ghost added needs/review Needs review size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 16, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 16, 2024
grolu
grolu approved these changes Sep 17, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@grolu grolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ghost ghost added reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/review Needs review labels Sep 17, 2024
holgerkoser
holgerkoser approved these changes Sep 17, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@petersutter petersutter merged commit 333d9c3 into master Sep 17, 2024
@petersutter petersutter deleted the fix-vite-warning branch September 17, 2024 14:48
@ghost ghost added the status/closed Issue is closed (either delivered or triaged) label Sep 17, 2024
holgerkoser added a commit that referenced this pull request Sep 20, 2024
@holgerkoser
Merge branch 'master' into enh/eslint-plugin-security
a337100 
# By Gardener Prow Robot (50) and others
# Via GitHub
* master: (62 commits)
  Update dependency codemirror to v5.65.18 (#2101)
  Update dependency vite to v5.4.6 [SECURITY] (#2096)
  Fix issues with hibernation schedule dialog (#2076)
  Hide SSH keypair rotation when SSH access disabled (#2077)
  remove unnecessary model-value binding (#2080)
  Fix vite warning (#2090)
  Update dependency vuetify to v3.7.2 (#2095)
  Update vueuse monorepo to v11.1.0 (#2094)
  Update dependency @vueuse/core to v11.1.0 (#2091)
  Update dependency chokidar to v4 (#2081)
  Update dependency @fontsource/roboto to v5.1.0 (#2078)
  Update dependency jose to v5.9.2 (#2087)
  Update dependency express to v4.20.0 [SECURITY] (#2084)
  Update dependency vue to v3.5.6 (#2089)
  Update Yarn to v4.5.0 (#2088)
  Update dependency vue to v3.5.5 (#2086)
  Update dependency vue-router to v4.4.5 (#2083)
  Update dependency express-static-gzip to v2.1.8 (#2082)
  Update dependency vue-router to v4.4.4 (#2075)
  Update dependency openid-client to v5.7.0 (#2069)
  ...

# Conflicts:
#	.pnp.cjs
#	backend/package.json
#	frontend/package.json
#	frontend/src/components/ShootAddons/GManageAddons.vue
#	packages/kube-client/package.json
#	packages/kube-config/package.json
#	packages/logger/package.json
#	packages/monitor/package.json
#	packages/request/package.json
#	yarn.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@holgerkoser holgerkoser holgerkoser approved these changes

@grolu grolu grolu approved these changes

Assignees

No one assigned

Labels

needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/closed Issue is closed (either delivered or triaged)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@petersutter @holgerkoser @grolu @gardener-robot-ci-2