Skip to content

app-crypt/signify: Fix call to undeclared function b64_pton #32097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
listout wants to merge 1 commit into from
Closed

app-crypt/signify: Fix call to undeclared function b64_pton #32097

listout wants to merge 1 commit into from

Conversation

@listout
Copy link
Contributor

@listout listout commented Jul 29, 2023

app-crypt/signify: Fix call to undeclared function b64_pton
0a89aff 
Upstream PR: aperezdc/signify#43

Closes: https://bugs.gentoo.org/894354
Signed-off-by: Brahmajit Das <brahmajit.xyz@gmail.com>
@gentoo-bot
Copy link

gentoo-bot commented Jul 29, 2023

Pull Request assignment

Submitter: @listout
Areas affected: ebuilds
Packages affected: app-crypt/signify

app-crypt/signify: patrick, @mgorny

Linked bugs

Bugs linked: 894354

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Jul 29, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

gentoo-repo-qa-bot commented Jul 29, 2023

Pull request CI report

Report generated at: 2023-07-29 20:35 UTC
Newest commit scanned: 0a89aff
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/6756b6475e/output.html

mgorny
mgorny approved these changes Jul 30, 2023
View reviewed changes
Copy link
Member

@mgorny mgorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

SoapGentoo
SoapGentoo reviewed Jul 30, 2023
View reviewed changes
app-crypt/signify/files/signify-31-fix-build-clang-16.patch
+++ b/base64.h
@@ -0,0 +1,2 @@
+int b64_pton(char const *, unsigned char *, size_t);
+int b64_ntop(unsigned char const *, size_t , char *, size_t);
Copy link
Member

@SoapGentoo SoapGentoo Jul 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny niggle: the declaration uses size_t which is not a built-in time. so this header actually requires a #include <stddef>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgorny mgorny mgorny approved these changes

+1 more reviewer

@SoapGentoo SoapGentoo SoapGentoo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@listout @gentoo-bot @gentoo-repo-qa-bot @mgorny @SoapGentoo