chore(ci): remove merge-artifacts job with Craft 2.21.1#215
Merged
Conversation
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Cli
Other
Bug Fixes 🐛Upgrade
Documentation 📚
Internal Changes 🔧
🤖 This preview updates automatically when you update the PR. |
Contributor
Codecov Results 📊✅ Patch coverage is 100.00%. Project has 3923 uncovered lines. Files with missing lines (63)
Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 67.04% 67.04% —%
==========================================
Files 97 97 —
Lines 11904 11904 —
Branches 0 0 —
==========================================
+ Hits 7981 7981 —
- Misses 3923 3923 —
- Partials 0 0 —Generated by Codecov Action |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Upgrade to Craft 2.21.1 which supports workflow-specific artifact filtering, eliminating the need to merge all CI artifacts into a single SHA-named artifact. Changes: - Bump minVersion to 2.21.1 - Replace requireNames with artifactProvider.config.artifacts - Remove merge-artifacts job from CI workflow - Update ci-status job dependencies
BYK
force-pushed
the
chore/craft-2.21-no-merge-artifacts
branch
from
b6b02a1 to
8164041
Compare
3 tasks
BYK
added a commit
that referenced
this pull request
Feb 11, 2026
## Summary Fixes the broken `curl` install (`curl https://cli.sentry.dev/install | bash`) which 404s because 0.9.0 shipped without platform binaries. ## Root Cause Craft's `patternToRegexp()` treats plain strings as **exact matches**, escaping `*` to `\*`. The pattern `'sentry-*'` in `.craft.yml` became `/^sentry\-\*$/` — matching only the literal string `"sentry-*"`, not actual artifact names like `sentry-linux-x64`. Only `gh-pages` and `npm-package` (exact name matches) were downloaded and uploaded to the GitHub release. All 5 platform binaries were silently skipped. ## Fix Use Craft's regex syntax (`'/^sentry-.*$/'` with enclosing slashes) so the pattern is parsed as an actual regex. This was introduced in #215 when migrating from `requireNames` (which used proper regex `/^sentry-.+$/`) to the new `artifactProvider` config.
This was referenced Feb 11, 2026
sentrivana
pushed a commit
to getsentry/sentry-python
that referenced
this pull request
Feb 12, 2026
…tering (#5444) ## Summary - Add named regex capture groups to `commit_patterns` in `.github/release.yml` for Craft's [title stripping](https://craft.sentry.dev/configuration/#title-stripping-default-behavior) feature - Remove the CI `merge` job by switching to Craft 2.21.1's [workflow-scoped artifact filtering](https://craft.sentry.dev/configuration/#github-artifact-provider-configuration) (same approach as getsentry/cli#215) - Modernize `.craft.yml` changelog config to object format - Modernize `scripts/bump-version.sh` to use Craft env vars ## Changes ### `.github/release.yml` - All `commit_patterns` now use `(?<type>...)` and `(?<scope>...)` named capture groups so Craft strips conventional commit prefixes from changelog entries - Added **Breaking Changes** category (`semver: major`) from Craft defaults - Expanded Internal Changes patterns to include `refactor|meta|perf` from Craft defaults ### `.craft.yml` - Bumped `minVersion` from `2.17.0` to `2.21.1` - Added `artifactProvider` config to fetch `artifact-*` directly from `ci.yml` workflow - Modernized changelog from separate keys to object format - Added explicit `preReleaseCommand` (was relying on the implicit default) ### `.github/workflows/ci.yml` - Removed the `merge` job (no longer needed with Craft 2.21.1 artifact filtering) - Removed `compression-level: '0'` from upload steps (was only needed for merging) ### `scripts/bump-version.sh` - Use `CRAFT_OLD_VERSION` / `CRAFT_NEW_VERSION` env vars instead of positional arguments (recommended by Craft docs)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade to Craft 2.21.1 which supports workflow-specific artifact filtering, eliminating the need to merge all CI artifacts into a single SHA-named artifact.
Changes
.craft.ymlminVersionto2.21.1requireNameswithartifactProvider.config.artifactsfor precise artifact filteringci.ymlworkflow:sentry-*,npm-package,gh-pages.github/workflows/ci.ymlmerge-artifactsjob (previously downloaded all artifacts and re-uploaded as${{ github.sha }})ci-statusjob dependencies and status checking logicBenefits
References