feat: Configure GitHub artifact provider to filter by workflow and name#709
Merged
feat: Configure GitHub artifact provider to filter by workflow and name#709
Conversation
Co-authored-by: burak.kaya <burak.kaya@sentry.io>
Contributor
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛Docker
Other
🤖 This preview updates automatically when you update the PR. |
Remove unnecessary inline comments that were overly explanatory for self-documenting code.
betegon
approved these changes
Jan 13, 2026
BYK
commented
Jan 13, 2026
- Export ArtifactPatternsSchema from schema - Move patternToRegexp and escapeRegex to utils/filters.ts - Restructure getArtifactsFromWorkflowRuns to pre-compute applicable patterns per workflow, eliminating redundant filter checks - Use Set to track seen artifact IDs instead of break statement - Implement two-phase download pipeline: download all in parallel, then unpack all in parallel for better I/O throughput - Add tests for new filter utility functions
Contributor
|
BYK
commented
Jan 13, 2026
- Use ArtifactPatternsSchema in GitHubArtifactsConfigSchema union - Remove re-export of patternToRegexp from github.ts - Update tests to import patternToRegexp from utils/filters.ts
Member
Author
|
@sentry review |
Member
Author
|
@cursoragent review |
Contributor
|
I've successfully completed the PR review and addressed the feedback. Here's a summary of what was done: Review Changes Summary1. Schema Already Correct ✅The 2. Redundant Workflow Filtering Already Fixed ✅The current implementation correctly uses 3. Fixed Resource Leak ✅This was the main issue that needed addressing. I modified
4. Tests Already Correct ✅Tests were already importing 5. All Tests Pass ✅Ran the full test suite - all 756 tests pass successfully. Changes Committed and PushedThe fix for the resource leak has been committed and pushed to the |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
…ing fails - Use Promise.allSettled instead of Promise.all for unpacking - Clean up temp files for failed unpacks to prevent resource leaks - Aggregate and report all unpacking errors Addresses review feedback to prevent disk space exhaustion from orphaned temporary files when unpacking operations fail. Co-authored-by: burak.kaya <burak.kaya@sentry.io>
BYK
added a commit
to getsentry/cli
that referenced
this pull request
Feb 9, 2026
## Summary
Upgrade to Craft 2.21.1 which supports workflow-specific artifact
filtering, eliminating the need to merge all CI artifacts into a single
SHA-named artifact.
## Changes
### `.craft.yml`
- Bump `minVersion` to `2.21.1`
- Replace `requireNames` with `artifactProvider.config.artifacts` for
precise artifact filtering
- Artifacts collected from `ci.yml` workflow: `sentry-*`, `npm-package`,
`gh-pages`
### `.github/workflows/ci.yml`
- Remove `merge-artifacts` job (previously downloaded all artifacts and
re-uploaded as `${{ github.sha }}`)
- Update `ci-status` job dependencies and status checking logic
## Benefits
- **Faster CI** — eliminates redundant download/upload step
- **Cleaner config** — artifact filtering at provider level with
explicit patterns
- **Better defaults** — leverages Craft 2.21.1 improvements
## References
- [Craft 2.21.1
Release](https://github.com/getsentry/craft/releases/tag/2.21.1)
- [PR #709: Configure GitHub artifact provider to filter by workflow and
name](getsentry/craft#709)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.