build: Update opentelemetry-proto to 0.7.0#4000
Merged
Conversation
Member
Author
|
@cleptric there are more approaches I'd like to explore. Leaving the choice to you as I'd like SDK teams to own this portion:
|
jan-auer
force-pushed
the
build/opentelemetry-proto-0.7.0
branch
from
b313c3a to
5701f44
Compare
jjbayer
approved these changes
Sep 5, 2024
Member
jjbayer
left a comment
jjbayer
left a comment
There was a problem hiding this comment.
Assuming that all the standalone spans that SDKs currently send use the sentry format, not the Otel format, this should be fine.
Member
Author
|
@cleptric I'm going to merge this as-is so I can move forward with dependency cleanup. Let's follow up with your preference at your convenience. |
Member
|
I feel like 1) and putting this into https://github.com/getsentry/sentry-protos. I rather not make us rely on Otel. The SDKs will maintain their own schema, so we have full control and can make changes and updates as we please. |
jan-auer
added a commit
that referenced
this pull request
Sep 6, 2024
* master: (27 commits) build: Update dialoguer and hostname (#4009) build: Update opentelemetry-proto to 0.7.0 (#4000) build: Update lru to 0.12.4 (#4008) build: Update cookie to 0.18.1 (#4007) feat(spans): Extract standalone CLS span metrics and performance score (#3988) build: Update cadence to 1.4.0 and statsdproxy to 0.2.0 (#4005) build: Update maxminddb to 0.24.0 (#4003) build: Update multer to 3.1.0 (#4002) build: Update regex and aho-corasick (#4001) build: Update sentry-kafka-schemas to 1.0.107 (#3999) build: Update dev-dependencies (#3998) build: Update itertools to 0.13.0 (#3993) build: Update brotli, zstd, flate2 (#3996) build: Update rdkafka to 0.36.2 (#3995) build: Update tikv-jemallocator to 0.6.0 (#3994) build: Update minidump to 0.22.0 (#3992) build: Update bindgen to 0.70.1 (#3991) build: Update chrono to 0.4.38 (#3990) feat(spans): initial MongoDB description scrubbing support (#3912) fix(spooler): Reduce number of disk reads (#3983) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the
opentelemetry-protodependency to the latest version. This changesthe serde deserializer for integers from numbers to strings. This means for
intValueand all timestamp fields, the client has to send strings now. Seeupdated tests for examples.
#skip-changelog