chore(internal): Refactor view hierarchy to be more hybrid SDK friendly#2492
Merged
krystofwoldrich merged 7 commits intomainfrom Jan 25, 2023
Merged
Conversation
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0b5447b | 333.98 ms | 415.86 ms | 81.88 ms |
| a42ea83 | 302.02 ms | 362.44 ms | 60.42 ms |
| b0c0b38 | 328.18 ms | 370.15 ms | 41.97 ms |
| 1b4791d | 348.40 ms | 376.16 ms | 27.76 ms |
| 4335f2b | 341.87 ms | 383.24 ms | 41.37 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 0b5447b | 1.73 MiB | 2.33 MiB | 622.45 KiB |
| a42ea83 | 1.73 MiB | 2.33 MiB | 622.45 KiB |
| b0c0b38 | 1.73 MiB | 2.33 MiB | 621.29 KiB |
| 1b4791d | 1.73 MiB | 2.33 MiB | 622.44 KiB |
| 4335f2b | 1.73 MiB | 2.33 MiB | 622.45 KiB |
Codecov ReportBase: 80.12% // Head: 80.12% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2492 +/- ##
=========================================
Coverage 80.12% 80.12%
- Complexity 3913 3916 +3
=========================================
Files 321 321
Lines 14779 14783 +4
Branches 1950 1951 +1
=========================================
+ Hits 11841 11845 +4
Misses 2170 2170
Partials 768 768
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
11 tasks
… used by the hybrid sdks
Contributor
Author
|
@markushi As we discussed, I've extracted the serialization into a separate method. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
Refactor the view hierarchy processor for hybrid SDKs use.
💡 Motivation and Context
💚 How did you test it?
With RN sample app
📝 Checklist
🔮 Next steps
#skip-changelog