Skip to content

chore(internal): Refactor view hierarchy to be more hybrid SDK friendly#2492

Merged
krystofwoldrich merged 7 commits intomainfrom
chore-view-hierarchy-more-hybrid-sdk-friendly
Jan 25, 2023
Merged

chore(internal): Refactor view hierarchy to be more hybrid SDK friendly#2492
krystofwoldrich merged 7 commits intomainfrom
chore-view-hierarchy-more-hybrid-sdk-friendly

Conversation

@krystofwoldrich
Copy link
Copy Markdown
Contributor

📜 Description

Refactor the view hierarchy processor for hybrid SDKs use.

💡 Motivation and Context

💚 How did you test it?

With RN sample app

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

#skip-changelog

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 23, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 307.62 ms 357.14 ms 49.52 ms
Size 1.73 MiB 2.33 MiB 622.45 KiB

Previous results on branch: chore-view-hierarchy-more-hybrid-sdk-friendly

Startup times

Revision Plain With Sentry Diff
0b5447b 333.98 ms 415.86 ms 81.88 ms
a42ea83 302.02 ms 362.44 ms 60.42 ms
b0c0b38 328.18 ms 370.15 ms 41.97 ms
1b4791d 348.40 ms 376.16 ms 27.76 ms
4335f2b 341.87 ms 383.24 ms 41.37 ms

App size

Revision Plain With Sentry Diff
0b5447b 1.73 MiB 2.33 MiB 622.45 KiB
a42ea83 1.73 MiB 2.33 MiB 622.45 KiB
b0c0b38 1.73 MiB 2.33 MiB 621.29 KiB
1b4791d 1.73 MiB 2.33 MiB 622.44 KiB
4335f2b 1.73 MiB 2.33 MiB 622.45 KiB

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 23, 2023

Codecov Report

Base: 80.12% // Head: 80.12% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (f516692) compared to base (37e95ce).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head f516692 differs from pull request most recent head 243952d. Consider uploading reports for the commit 243952d to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2492   +/-   ##
=========================================
  Coverage     80.12%   80.12%           
- Complexity     3913     3916    +3     
=========================================
  Files           321      321           
  Lines         14779    14783    +4     
  Branches       1950     1951    +1     
=========================================
+ Hits          11841    11845    +4     
  Misses         2170     2170           
  Partials        768      768           
Impacted Files Coverage Δ
...ry/src/main/java/io/sentry/SentryEnvelopeItem.java 88.31% <100.00%> (-0.30%) ⬇️
...in/java/io/sentry/util/JsonSerializationUtils.java 95.45% <100.00%> (+2.59%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@krystofwoldrich
Copy link
Copy Markdown
Contributor Author

@markushi @romtsn I optimized what I know, but I'm unsure how to expose only the byte[] for the RN SDK.

@krystofwoldrich
Copy link
Copy Markdown
Contributor Author

@markushi As we discussed, I've extracted the serialization into a separate method.
ac751e1 (#2492)

Copy link
Copy Markdown
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, looks good to me!

Copy link
Copy Markdown
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@krystofwoldrich krystofwoldrich enabled auto-merge (squash) January 25, 2023 07:56
@krystofwoldrich krystofwoldrich merged commit 85fed9a into main Jan 25, 2023
@krystofwoldrich krystofwoldrich deleted the chore-view-hierarchy-more-hybrid-sdk-friendly branch January 25, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants