Conversation
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d091239+dirty | 425.61 ms | 447.11 ms | 21.50 ms |
| d760caf+dirty | 367.76 ms | 388.06 ms | 20.30 ms |
| b868b53+dirty | 339.52 ms | 369.84 ms | 30.32 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d091239+dirty | 17.73 MiB | 19.95 MiB | 2.22 MiB |
| d760caf+dirty | 17.73 MiB | 20.03 MiB | 2.30 MiB |
| b868b53+dirty | 17.73 MiB | 19.95 MiB | 2.22 MiB |
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
|
I've simplified the view hierarchy function based on |
Let me know once this is ready to be reviewed again since there are conflicts to be solved yet + using the new Android API. |
|
@marandaneto |
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d091239+dirty | 1251.49 ms | 1276.75 ms | 25.26 ms |
| d760caf+dirty | 1266.80 ms | 1290.92 ms | 24.12 ms |
| b868b53+dirty | 1274.90 ms | 1305.68 ms | 30.78 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d091239+dirty | 2.36 MiB | 2.74 MiB | 384.64 KiB |
| d760caf+dirty | 2.36 MiB | 2.81 MiB | 462.03 KiB |
| b868b53+dirty | 2.36 MiB | 2.74 MiB | 384.64 KiB |
marandaneto
left a comment
There was a problem hiding this comment.
LGTM after upgrading the Android SDK with the latest changes (dupe of VH attachments)
|
Waiting for https://github.com/getsentry/sentry-java release, likely |
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Add View Hierarchy ([#2708](https://github.com/getsentry/sentry-react-native/pull/2708))If none of the above apply, you can opt out of this check by adding |
📢 Type of change
📜 Description
Works both on iOS and Android but it can't be merged until stable releases of the native SDKs.
💡 Motivation and Context
💚 How did you test it?
sample app,
📝 Checklist
🔮 Next steps