Skip to content

fix(internal): Do not attach view hierarchy to hybrid sdks events#2513

Merged
krystofwoldrich merged 1 commit intomainfrom
attach-view-hierarchy-not-for-hybrid
Feb 3, 2023
Merged

fix(internal): Do not attach view hierarchy to hybrid sdks events#2513
krystofwoldrich merged 1 commit intomainfrom
attach-view-hierarchy-not-for-hybrid

Conversation

@krystofwoldrich
Copy link
Copy Markdown
Contributor

@krystofwoldrich krystofwoldrich commented Feb 2, 2023

📜 Description

The view hierarchy the same way as screenshots would appear twice if not checked for hybrid sdks.

💡 Motivation and Context

💚 How did you test it?

unit tests

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

#skip-changelog

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 2, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 309.08 ms 351.84 ms 42.75 ms
Size 1.73 MiB 2.33 MiB 620.59 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
5fa24ec 326.29 ms 384.53 ms 58.24 ms
c1399c1 345.06 ms 385.49 ms 40.43 ms

App size

Revision Plain With Sentry Diff
5fa24ec 1.73 MiB 2.33 MiB 620.61 KiB
c1399c1 1.73 MiB 2.33 MiB 620.61 KiB

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 2, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@14c083a). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2513   +/-   ##
=======================================
  Coverage        ?   80.17%           
  Complexity      ?     3943           
=======================================
  Files           ?      323           
  Lines           ?    14896           
  Branches        ?     1966           
=======================================
  Hits            ?    11943           
  Misses          ?     2178           
  Partials        ?      775           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@krystofwoldrich krystofwoldrich merged commit 7da2a31 into main Feb 3, 2023
@krystofwoldrich krystofwoldrich deleted the attach-view-hierarchy-not-for-hybrid branch February 3, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants