Skip to content

chore(internal): Add snapshot view hierarchy as byte array#2508

Merged
krystofwoldrich merged 2 commits intomainfrom
chore-view-hierarchy-as-byte-array
Feb 2, 2023
Merged

chore(internal): Add snapshot view hierarchy as byte array#2508
krystofwoldrich merged 2 commits intomainfrom
chore-view-hierarchy-as-byte-array

Conversation

@krystofwoldrich
Copy link
Copy Markdown
Contributor

📜 Description

Even more simple interface for hybrid SDKs.

💡 Motivation and Context

getsentry/sentry-react-native#2708 (comment)

💚 How did you test it?

integration tests

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

#skip-changelog

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 1, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 359.37 ms 406.42 ms 47.05 ms
Size 1.73 MiB 2.33 MiB 620.61 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
5fa24ec 326.29 ms 384.53 ms 58.24 ms
c1399c1 345.06 ms 385.49 ms 40.43 ms

App size

Revision Plain With Sentry Diff
5fa24ec 1.73 MiB 2.33 MiB 620.61 KiB
c1399c1 1.73 MiB 2.33 MiB 620.61 KiB

Previous results on branch: chore-view-hierarchy-as-byte-array

Startup times

Revision Plain With Sentry Diff
80318af 292.28 ms 371.70 ms 79.42 ms

App size

Revision Plain With Sentry Diff
80318af 1.73 MiB 2.33 MiB 620.61 KiB

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 1, 2023

Codecov Report

Base: 80.18% // Head: 80.18% // No change to project coverage 👍

Coverage data is based on head (6c5be99) compared to base (658c557).
Patch has no changes to coverable lines.

❗ Current head 6c5be99 differs from pull request most recent head 503d2ea. Consider uploading reports for the commit 503d2ea to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2508   +/-   ##
=========================================
  Coverage     80.18%   80.18%           
  Complexity     3943     3943           
=========================================
  Files           323      323           
  Lines         14896    14896           
  Branches       1966     1966           
=========================================
  Hits          11944    11944           
  Misses         2178     2178           
  Partials        774      774           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Copy Markdown
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@krystofwoldrich krystofwoldrich merged commit 14c083a into main Feb 2, 2023
@krystofwoldrich krystofwoldrich deleted the chore-view-hierarchy-as-byte-array branch February 2, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants